Skip to content

chore(deps): add check-dependency-version for devDependencies#6323

Merged
SoonIter merged 12 commits intomainfrom
chore/unify-deps
Jul 18, 2024
Merged

chore(deps): add check-dependency-version for devDependencies#6323
SoonIter merged 12 commits intomainfrom
chore/unify-deps

Conversation

@SoonIter
Copy link
Copy Markdown
Member

@SoonIter SoonIter commented Apr 22, 2024 •
edited
Loading

Summary

close #5477

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SoonIter SoonIter requested a review from jerrykingxyz as a code owner April 22, 2024 14:12
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 22, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit caf15b0
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6698b8faa509e300086a7736

@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Apr 25, 2024

@SoonIter can you resolve the conflicts and fix the CI~

@SoonIter SoonIter marked this pull request as draft April 26, 2024 08:21
@SoonIter SoonIter force-pushed the chore/unify-deps branch 2 times, most recently from d7b4157 to 1f8d8b3 Compare April 27, 2024 03:52
@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented May 8, 2024

can you resolve the conflicts and CI again ❤️

@SoonIter
Copy link
Copy Markdown
Member Author

SoonIter commented May 9, 2024

can you resolve the conflicts and CI again ❤️

sorry, i almost forgot it, delayed by phantom dependence problem and react multiple versions...

separate the bench case from dependency graph might be better, but it needs the refactor of benchmark

@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented May 9, 2024

separate the bench case from dependency graph might be better

The bench case need to use workspace:* protocol to reference the local Rspack, so it may not be separated from the workspace.

Can this dependency issue be solved with a different approach?

@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Jun 20, 2024

@SoonIter bump

This was referenced Jul 15, 2024
Merged
Closed
@SoonIter SoonIter force-pushed the chore/unify-deps branch 2 times, most recently from bfb795c to da810ab Compare July 16, 2024 10:58
@SoonIter SoonIter changed the title chore(deps): add check-dependency-version chore(deps): add check-dependency-version for devDependencies Jul 16, 2024
@SoonIter SoonIter marked this pull request as ready for review July 16, 2024 11:27
@SoonIter SoonIter requested a review from chenjiahan July 18, 2024 06:51
@SoonIter SoonIter enabled auto-merge (squash) July 18, 2024 06:55
@SoonIter SoonIter merged commit 8f941c5 into main Jul 18, 2024
@SoonIter SoonIter deleted the chore/unify-deps branch July 18, 2024 07:07
@SoonIter SoonIter mentioned this pull request Jul 18, 2024
Merged
2 tasks
@chenjiahan chenjiahan mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

Assignees

@SoonIter SoonIter

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use consistent version of dependency

2 participants

@SoonIter @chenjiahan