Skip to content

chore: ignore react upgrades#5474

Merged
Boshen merged 1 commit intomainfrom
same-react
Jan 26, 2024
Merged

chore: ignore react upgrades#5474
Boshen merged 1 commit intomainfrom
same-react

Conversation

@Boshen
Copy link
Copy Markdown
Contributor

@Boshen Boshen commented Jan 25, 2024

Otherwise e2e will error out with:

main.js:31267 Warning: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 25, 2024
@Boshen Boshen changed the title chore: use the same react and react-dom versions inside this monorepo fix(playground): pin the react version to prevent e2e from crashing Jan 26, 2024
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jan 26, 2024
@Boshen Boshen changed the title fix(playground): pin the react version to prevent e2e from crashing chore: ignore react upgrades Jan 26, 2024
@github-actions github-actions bot removed the release: bug fix release: bug related release(mr only) label Jan 26, 2024
@Boshen Boshen merged commit f5de99b into main Jan 26, 2024
@Boshen Boshen deleted the same-react branch January 26, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant