Conversation
h-a-n-a
commented
Sep 4, 2023
5c7ea81 to
9b6d63b
Compare
ahabhgk
approved these changes
Sep 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initializes future flags. Rspack learned the technique for future flag from remix team.
Future flagging is fundamentally the same as other terms you may heard of like
feature-gates,feature-flags.Essentially, in Rspack, when it comes to adopting a deprecation or a newly added feature that differs from
the behavior of the previous version, a new future flag is added.
For example:
When adopting a new breaking behavior in Rspack, three steps are included:
for the default behavior, this flag is off. You can adopt this feature by switching the flag.
At the same time, a deprecation message with regard to the breaking will also be added.
At this stage, you can still switch to the old implementation. This leaves people some time
for adopting the new behavior later. For people who turned off the flag (which is enabled in this version),
a deprecation message will be used as a heads-up.
In summary, developers have time of less than two releases to adopt to the new behavior.
This strategy is subject to change when it hits to our first major version.
Test Plan
Not necessary for now.