fix(react-refresh): lazily access module.exports to prevent unexpected/potential TDZ error#2714
Merged
fix(react-refresh): lazily access module.exports to prevent unexpected/potential TDZ error#2714
module.exports to prevent unexpected/potential TDZ error#2714Conversation
🦋 Changeset detectedLatest commit: ca7ee35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bf5a5c4 to
b64cfcd
Compare
93d5641 to
ca7ee35
Compare
underfin
approved these changes
Apr 13, 2023
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The causes/details could be seen at pmmmwh/react-refresh-webpack-plugin#190.
The problem is caused by eagerly accessing some un-initialized variables declared by
const. The accessing is done due to the react-refresh need to access each export of modules. By making accessing laziness, we solved the problem.This PR solves the problem by lazily accessing
module.exports.This PR may have potential performance problems:
Credit to @underfin for pair programming with me.
Related issue (if exists)
Closes #2697.
Summary
🤖 Generated by Copilot at 93d5641
This pull request fixes a potential error with the react-refresh plugin and the temporal dead zone issue by lazily accessing the
module.exportsobject. It also improves the hot module replacement functionality by deferring the refresh function with a promise. The changes affect the@rspack/bindingpackage and thecrates/rspack_plugin_javascript/src/visitors/swc_visitor/react.rsfile.Related issue (if exists)
Walkthrough
🤖 Generated by Copilot at 93d5641
module.exports(link, link)@rspack/bindingpackage with patch version and message (link)