Skip to content

revert: "feat: optimize generated getter for const export"#14151

Merged
ahabhgk merged 2 commits into
mainfrom
revert-14045-optimize-getter
May 26, 2026
Merged

revert: "feat: optimize generated getter for const export"#14151
ahabhgk merged 2 commits into
mainfrom
revert-14045-optimize-getter

Conversation

@ahabhgk

@ahabhgk ahabhgk commented May 26, 2026

Copy link
Copy Markdown
Contributor

Reverts #14045

Copilot AI review requested due to automatic review settings May 26, 2026 04:01
Copilot AI reviewed May 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 26, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 53921100e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/rspack_core/src/init_fragment.rs
Comment thread crates/rspack_plugin_runtime/src/runtime_module/runtime/create_fake_namespace_object.ejs
@ahabhgk ahabhgk enabled auto-merge (squash) May 26, 2026 04:11
@github-actions

github-actions Bot commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 91f22ff to perf(core): use dense storage for dependency connections (#14148) by hardfist

🙈 Size remains the same at 61.76MB

@github-actions

github-actions Bot commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
popular-libs 1.7 MB -2.2 KB (-0.1%)
react-10k 5.7 MB -16.0 KB (-0.3%)
react-1k 826.3 KB -951.0 B (-0.1%)
react-5k 2.7 MB -7.0 KB (-0.3%)
ui-components 4.8 MB -283.0 B (-0.0%)
📋 Detailed Reports (Click to expand)

📁 popular-libs

Path: ../build-tools-performance/cases/popular-libs/dist/rsdoctor-data.json

📌 Baseline Commit: 5b17418b08 | PR: #14148

Metric Current Baseline Change
📊 Total Size 1.7 MB 1.7 MB -2.2 KB (-0.1%)
📄 JavaScript 1.7 MB 1.7 MB -2.2 KB (-0.1%)
🎨 CSS 0 B 0 B 0
🌐 HTML 289.0 B 289.0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: popular-libs Bundle Diff

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 5b17418b08 | PR: #14148

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -16.0 KB (-0.3%)
📄 JavaScript 5.7 MB 5.7 MB -16.0 KB (-0.3%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 328.0 B 328.0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 5b17418b08 | PR: #14148

Metric Current Baseline Change
📊 Total Size 826.3 KB 827.2 KB -951.0 B (-0.1%)
📄 JavaScript 826.0 KB 826.9 KB -951.0 B (-0.1%)
🎨 CSS 0 B 0 B 0
🌐 HTML 328.0 B 328.0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 5b17418b08 | PR: #14148

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB -7.0 KB (-0.3%)
📄 JavaScript 2.7 MB 2.7 MB -7.0 KB (-0.3%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 328.0 B 328.0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 5b17418b08 | PR: #14148

Metric Current Baseline Change
📊 Total Size 4.8 MB 4.8 MB -283.0 B (-0.0%)
📄 JavaScript 4.7 MB 4.7 MB -283.0 B (-0.0%)
🎨 CSS 107.0 KB 107.0 KB 0
🌐 HTML 328.0 B 328.0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@codspeed-hq

codspeed-hq Bot commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 2.17%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 (👁 1) regressed benchmark
✅ 36 untouched benchmarks
⏩ 25 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
👁 Simulation rust@create_full_hash 6.1 ms 6.2 ms -2.17%

Comparing revert-14045-optimize-getter (91f22ff) with main (5b17418)

Open in CodSpeed

Footnotes

  1. 25 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ahabhgk ahabhgk force-pushed the revert-14045-optimize-getter branch from 5392110 to 91f22ff Compare May 26, 2026 04:29
@ahabhgk ahabhgk merged commit 31647e8 into main May 26, 2026
37 checks passed
@ahabhgk ahabhgk deleted the revert-14045-optimize-getter branch May 26, 2026 05:59
@ahabhgk ahabhgk mentioned this pull request May 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@JSerFeng JSerFeng JSerFeng approved these changes
@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder LingyuCoder is a code owner
@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahabhgk @JSerFeng