Skip to content

fix(cli): use rspack-merge for config extends#13869

Merged
chenjiahan merged 9 commits into
mainfrom
issue-13732
May 6, 2026
Merged

fix(cli): use rspack-merge for config extends#13869
chenjiahan merged 9 commits into
mainfrom
issue-13732

Conversation

@intellild

@intellild intellild commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

fix #13732

webpack-cli use webpack-merge for resolving config extends.

rspack-merge implements special handling for Rspack semantics, such as deduplicating loaders by their test rules. cleverMerge is a generic utility function.For the CLI extends scenario, rspack-merge is indeed the more suitable option.

Related links

#13732

https://webpack.js.org/configuration/extending-configurations/

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions Bot added the release: bug fix release: bug related release(mr only) label Apr 29, 2026
@intellild intellild linked an issue Apr 29, 2026 that may be closed by this pull request
[Bug]: extended configs don't inherit plugins #13732
Closed
@github-actions

github-actions Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 1bcfd84 to fix: align module external remapping with webpack (#13802) by Fy

🙈 Size remains the same at 61.89MB

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5ff35d4
Status: ✅  Deploy successful!
Preview URL: https://3d34b8ea.rspack-v2.pages.dev
Branch Preview URL: https://issue-13732.rspack-v2.pages.dev

View logs

@codspeed-hq

codspeed-hq Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 34 untouched benchmarks

Comparing issue-13732 (1bcfd84) with main (4cddada)

Open in CodSpeed

@intellild intellild marked this pull request as ready for review April 29, 2026 03:49
@intellild intellild requested a review from hardfist as a code owner April 29, 2026 03:49
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Apr 29, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46f935783d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/rspack-cli/src/utils/loadConfig.ts
@github-actions

github-actions Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 6 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
popular-libs 1.7 MB +289.0 B (0.0%)
react-10k 5.7 MB +328.0 B (0.0%)
react-1k 826.4 KB +328.0 B (0.0%)
react-5k 2.7 MB +328.0 B (0.0%)
rome 1.6 MB 0
ui-components 4.8 MB +328.0 B (0.0%)
📋 Detailed Reports (Click to expand)

📁 popular-libs

Path: ../build-tools-performance/cases/popular-libs/dist/rsdoctor-data.json

📌 Baseline Commit: 4cddada653 | PR: #13802

Metric Current Baseline Change
📊 Total Size 1.7 MB 1.7 MB +289.0 B (0.0%)
📄 JavaScript 1.7 MB 1.7 MB 0
🎨 CSS 0 B 0 B 0
🌐 HTML 289.0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: popular-libs Bundle Diff

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 4cddada653 | PR: #13802

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB +328.0 B (0.0%)
📄 JavaScript 5.7 MB 5.7 MB 0
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 328.0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 4cddada653 | PR: #13802

Metric Current Baseline Change
📊 Total Size 826.4 KB 826.1 KB +328.0 B (0.0%)
📄 JavaScript 826.1 KB 826.1 KB 0
🎨 CSS 0 B 0 B 0
🌐 HTML 328.0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 4cddada653 | PR: #13802

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB +328.0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB 0
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 328.0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 4cddada653 | PR: #13802

Metric Current Baseline Change
📊 Total Size 4.8 MB 4.8 MB +328.0 B (0.0%)
📄 JavaScript 4.7 MB 4.7 MB 0
🎨 CSS 106.8 KB 106.8 KB 0
🌐 HTML 328.0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@intellild intellild added the bug Something isn't working label Apr 29, 2026
@intellild
feat(rspack-cli): add test for various config extends scenarios
ac39b19 
add test for file protocol, require.resolve, JSON config, and multiple config extends
add recursive extends detection to prevent circular dependencies
update tests to cover all new extends scenarios
@intellild
restore comments
85624ab
@intellild
update docs
5ff35d4
@intellild intellild changed the title fix(cli): use webpack-merge for config extends fix(cli): use rspack-merge for config extends Apr 30, 2026
chenjiahan
chenjiahan reviewed May 6, 2026
View reviewed changes
Comment thread packages/rspack-cli/src/utils/loadConfig.ts Outdated
@intellild intellild requested a review from chenjiahan May 6, 2026 09:40
chenjiahan
chenjiahan approved these changes May 6, 2026
View reviewed changes

@chenjiahan chenjiahan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan chenjiahan merged commit b9788fb into main May 6, 2026
34 checks passed
@chenjiahan chenjiahan deleted the issue-13732 branch May 6, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@chenjiahan chenjiahan chenjiahan approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

bug Something isn't working release: bug fix release: bug related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: extended configs don't inherit plugins

2 participants

@intellild @chenjiahan