fix(rstest): resolve manual mock targets with resolver by 9aoy · Pull Request #13439 · web-infra-dev/rspack

9aoy · 2026-03-23T08:07:39Z

Summary

resolve manual mock targets with resolver.

Fix the case where a mocked relative request resolves through a directory entry file such as index.js / index.ts.

Before this change, rs.mock("./common") would resolve the mock target as ./__mocks__/common, even when ./common actually resolved to ./common/index.ts. That caused rstest to miss mocks placed under ./common/__mocks__/index.

After this change, when a relative mock request points to a real directory, rstest resolves the manual mock to the nested directory form:

source: ./common
actual module: ./common/index.ts
manual mock: ./common/__mocks__/index

Checklist

Tests updated (or not required).
Documentation updated (or not required).

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ca43b01c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/rspack_plugin_rstest/src/parser_plugin.rs

github-actions · 2026-03-23T08:22:28Z

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary

Project	Total Size	Change
react-10k	5.7 MB	0
react-1k	826.2 KB	0
react-5k	2.7 MB	0
ui-components	2.3 MB	0
rome	984.2 KB	0

Generated by Rsdoctor GitHub Action

github-actions · 2026-03-23T08:59:46Z

📦 Binary Size-limit

Comparing 2a4732a to chore(ci): remove stale miri config (#13465) by neverland

❌ Size increased by 21.00KB from 48.97MB to 48.99MB (⬆️0.04%)

codspeed-hq · 2026-03-23T09:25:24Z

Merging this PR will not alter performance

✅ 23 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing rstest-mock-resolve (2a4732a) with main (1c683d6)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

fi3ework

should respect mainFiles instead of hard code index
better to use resolver to resolve instead of manually is_dir

github-actions · 2026-03-25T08:34:23Z

📝 Ecosystem CI detail: Open

suite	result
modernjs	❌ failure
examples	✅ success
rsbuild-rsc-plugin	✅ success
devserver	✅ success
plugin	❌ failure
rslib	❌ failure
rsdoctor	✅ success
lynx-stack	❌ failure
rstest	❌ failure
rsbuild	✅ success
rspress	✅ success

…stest-mock-resolve

cloudflare-workers-and-pages · 2026-03-25T09:18:33Z

Deploying rspack with Cloudflare Pages

Latest commit:	`2a4732a`
Status:	✅ Deploy successful!
Preview URL:	https://ca5a9b27.rspack-v2.pages.dev
Branch Preview URL:	https://rstest-mock-resolve.rspack-v2.pages.dev

View logs

github-actions · 2026-03-25T11:12:18Z

📝 Ecosystem CI detail: Open

suite	result
devserver	✅ success
plugin	✅ success
examples	✅ success
rsbuild-rsc-plugin	✅ success
lynx-stack	❌ failure
rstest	✅ success
modernjs	❌ failure
rsdoctor	✅ success
rspress	✅ success
rslib	✅ success
rsbuild	✅ success

fi3ework · 2026-03-26T10:55:42Z

👍🏻

9aoy added 2 commits March 23, 2026 16:04

fix(rstest): resolve directory entry manual mocks from nested __mocks__

f6fbb86

docs: update

4ca43b0

9aoy requested a review from LingyuCoder as a code owner March 23, 2026 08:07

chatgpt-codex-connector bot reviewed Mar 23, 2026

View reviewed changes

crates/rspack_plugin_rstest/src/parser_plugin.rs Outdated Show resolved Hide resolved

crates/rspack_plugin_rstest/src/parser_plugin.rs Outdated Show resolved Hide resolved

github-actions bot added the release: bug fix release: bug related release(mr only) label Mar 23, 2026

github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 23, 2026

9aoy requested a review from fi3ework March 24, 2026 06:13

fi3ework reviewed Mar 24, 2026

View reviewed changes

fix(rstest): resolve manual mock targets with resolver

2c3aff5

9aoy added 2 commits March 25, 2026 17:18

fix: mock builtin module

88d3182

Merge branch 'main' of https://github.com/web-infra-dev/rspack into r…

2a4732a

…stest-mock-resolve

9aoy requested a review from fi3ework March 26, 2026 02:53

9aoy changed the title ~~fix(rstest): resolve directory entry manual mocks from nested __mocks__~~ fix(rstest): resolve manual mock targets with resolver Mar 26, 2026

fi3ework approved these changes Mar 26, 2026

View reviewed changes

fi3ework merged commit 12f9230 into main Mar 26, 2026
49 checks passed

fi3ework deleted the rstest-mock-resolve branch March 26, 2026 10:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(rstest): resolve manual mock targets with resolver#13439

fix(rstest): resolve manual mock targets with resolver#13439
fi3ework merged 5 commits intomainfrom
rstest-mock-resolve

9aoy commented Mar 23, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

fi3ework left a comment

Uh oh!

github-actions bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

fi3ework commented Mar 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

9aoy commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related links

Checklist

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rsdoctor Bundle Diff Analysis

Uh oh!

github-actions bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Binary Size-limit

Uh oh!

codspeed-hq bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

fi3ework left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rspack with Cloudflare Pages

Uh oh!

github-actions bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fi3ework commented Mar 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

9aoy commented Mar 23, 2026 •

edited

Loading

github-actions bot commented Mar 23, 2026 •

edited

Loading

github-actions bot commented Mar 23, 2026 •

edited

Loading

codspeed-hq bot commented Mar 23, 2026 •

edited

Loading

github-actions bot commented Mar 25, 2026 •

edited

Loading

cloudflare-workers-and-pages bot commented Mar 25, 2026 •

edited

Loading

github-actions bot commented Mar 25, 2026 •

edited

Loading