feat: add EsmNodeTargetPlugin for ESM-aware node builtin externals by JSerFeng · Pull Request #13370 · web-infra-dev/rspack

JSerFeng · 2026-03-16T07:52:28Z

Summary

Add EsmNodeTargetPlugin that externalizes all Node.js builtin modules with dependency-type-aware external types:
- EsmImportSpecifier | EsmImport | EsmExportImport → module external type
- DynamicImport → import external type
- Otherwise → node-commonjs external type
Register as BuiltinPluginName in the binding layer, but intentionally not exported from @rspack/core public API
Designed to be used internally by Rslib when targeting ESM node output

Changes

Rust: New EsmNodeTargetPlugin in rspack_plugin_externals crate, hooks into NormalModuleFactoryFactorize
Binding: Added EsmNodeTargetPlugin variant to BuiltinPluginName enum
JS: Internal wrapper in builtin-plugin/EsmNodeTargetPlugin.ts (not exported from @rspack/core)
Test: Added esmOutputCases/externals/esm-node-target test case verifying ESM import, re-export, and dynamic import external types

chatgpt-codex-connector · 2026-03-16T07:52:33Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot

Pull request overview

Adds a new builtin plugin that externalizes Node.js built-in modules appropriately for ESM output, and introduces an ESM output snapshot test case to validate external type selection.

Changes:

Introduce EsmNodeTargetPlugin (TS wrapper + Rust implementation) and wire it through the binding builtin plugin registry.
Add a new ESM output externals test case (esm-node-target) with snapshot coverage.
Export the new plugin from the builtin-plugin barrel.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/rspack-test/esmOutputCases/externals/esm-node-target/rspack.config.js	Registers the new builtin plugin in a dedicated ESM output externals fixture.
tests/rspack-test/esmOutputCases/externals/esm-node-target/index.js	Test asserting correct external behavior for ESM import, ESM re-export, and dynamic import.
tests/rspack-test/esmOutputCases/externals/esm-node-target/snapshots/esm.snap.txt	Snapshot expectations for the generated ESM output modules.
packages/rspack/src/builtin-plugin/index.ts	Re-export `EsmNodeTargetPlugin` from the builtin plugin index.
packages/rspack/src/builtin-plugin/EsmNodeTargetPlugin.ts	TS wrapper to register the builtin plugin via `BuiltinPluginName`.
crates/rspack_plugin_externals/src/lib.rs	Expose the new Rust plugin module from the externals crate.
crates/rspack_plugin_externals/src/esm_node_target_plugin.rs	Implements externals factorization for Node builtins with dependency-type-based external types.
crates/rspack_binding_api/src/raw_options/raw_builtins/mod.rs	Adds `BuiltinPluginName::EsmNodeTargetPlugin` and constructs the plugin in the builtin registry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rspack_plugin_externals/src/esm_node_target_plugin.rs

tests/rspack-test/esmOutputCases/externals/esm-node-target/__snapshots__/esm.snap.txt

github-actions · 2026-03-16T08:06:58Z

📦 Binary Size-limit

Comparing b78bdb4 to chore: release 2.0.0-beta.7 (#13385) by harpsealjs

❌ Size increased by 640bytes from 48.70MB to 48.70MB (⬆️0.00%)

…nction Replace the custom factorize hook with an ExternalsPlugin function item that uses "module-import" external type for ESM dependencies. Extract shared NODE_BUILTINS to a common module to avoid duplication between EsmNodeTargetPlugin and NodeTargetPlugin.

github-actions · 2026-03-16T08:37:16Z

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary

Project	Total Size	Change
react-10k	5.7 MB	0
react-1k	826.2 KB	0
react-5k	2.7 MB	0
rome	984.2 KB	0
ui-components	2.3 MB	0

Generated by Rsdoctor GitHub Action

codspeed-hq · 2026-03-16T08:40:59Z

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing feat/esm-node-target-plugin (b78bdb4) with main (35c2f4a)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Add a new configuration option to RslibPlugin that enables ESM-aware externalization of Node.js builtin modules. Update the test to use RslibPlugin instead of raw builtin plugin registration.

…ibility Match NodeTargetPlugin's ^node: regex behavior so that future Node.js builtins are automatically externalized without updating the list.

chatgpt-codex-connector · 2026-03-16T11:07:52Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

JSerFeng · 2026-03-18T02:32:44Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 803baca68c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/rspack_plugin_externals/src/esm_node_target_plugin.rs

crates/rspack_plugin_externals/src/node_builtins.rs

JSerFeng requested a review from hardfist as a code owner March 16, 2026 07:52

Copilot AI review requested due to automatic review settings March 16, 2026 07:52

github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Mar 16, 2026

Copilot started reviewing on behalf of JSerFeng March 16, 2026 07:53 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

JSerFeng marked this pull request as draft March 16, 2026 08:02

JSerFeng force-pushed the feat/esm-node-target-plugin branch from 6ad7a69 to ccd4471 Compare March 16, 2026 08:23

JSerFeng added 2 commits March 16, 2026 16:59

feat(rslib): add external_esm_node_builtin option to RslibPlugin

8e91b0c

Add a new configuration option to RslibPlugin that enables ESM-aware externalization of Node.js builtin modules. Update the test to use RslibPlugin instead of raw builtin plugin registration.

fix: treat all node: prefixed requests as builtins for forward-compat…

803baca

…ibility Match NodeTargetPlugin's ^node: regex behavior so that future Node.js builtins are automatically externalized without updating the list.

JSerFeng marked this pull request as ready for review March 16, 2026 11:07

JSerFeng requested a review from LingyuCoder as a code owner March 16, 2026 11:07

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

crates/rspack_plugin_externals/src/esm_node_target_plugin.rs Outdated Show resolved Hide resolved

crates/rspack_plugin_externals/src/node_builtins.rs Show resolved Hide resolved

fix: use node-commonjs as fallback external type in EsmNodeTargetPlugin

b78bdb4

JSerFeng enabled auto-merge (squash) March 18, 2026 03:37

Timeless0911 approved these changes Mar 18, 2026

View reviewed changes

JSerFeng merged commit ceecf44 into main Mar 18, 2026
47 checks passed

JSerFeng deleted the feat/esm-node-target-plugin branch March 18, 2026 03:39

Timeless0911 mentioned this pull request Mar 24, 2026

fix(core): use esm-aware node built-in externals web-infra-dev/rslib#1552

Merged

2 tasks

web-infra-dev deleted a comment from affiliatemarketcommissions-hue Mar 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add EsmNodeTargetPlugin for ESM-aware node builtin externals#13370

feat: add EsmNodeTargetPlugin for ESM-aware node builtin externals#13370
JSerFeng merged 4 commits intomainfrom
feat/esm-node-target-plugin

JSerFeng commented Mar 16, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

JSerFeng commented Mar 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

JSerFeng commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Binary Size-limit

Uh oh!

github-actions bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rsdoctor Bundle Diff Analysis

Uh oh!

codspeed-hq bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

JSerFeng commented Mar 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JSerFeng commented Mar 16, 2026 •

edited

Loading

github-actions bot commented Mar 16, 2026 •

edited

Loading

github-actions bot commented Mar 16, 2026 •

edited

Loading

codspeed-hq bot commented Mar 16, 2026 •

edited

Loading