feat!: remove .wasm from default js extensions#13321
Merged
chenjiahan merged 4 commits intomainfrom Mar 13, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b8fb451ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes WebAssembly (.wasm) from the default jsExtensions list, which in turn updates the default resolver extension list to no longer include .wasm.
Changes:
- Remove
.wasmfromjsExtensionsin the TypeScript defaults implementation. - Mirror the same change in the Rust builder defaults.
- Update JS/Rust snapshot expectations to match the new default resolve extensions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/rspack-test/defaultsCases/default/base.js | Updates default-case expected output to remove .wasm from resolved extensions. |
| packages/rspack/src/config/defaults.ts | Removes .wasm from jsExtensions in the TS defaults for resolve behavior. |
| crates/rspack/tests/snapshots/defaults__default_options.snap | Updates snapshot of default compiler options to remove .wasm from extensions. |
| crates/rspack/src/builder/mod.rs | Removes .wasm from js_extensions in Rust defaults to keep parity with TS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff Analysis
Found 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
|
📝 Benchmark detail: Open
|
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 49.01MB |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Deploying rspack with
|
| Latest commit: |
5b6c4ea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://769db438.rspack-v2.pages.dev |
| Branch Preview URL: | https://codex-jsextensions-wasm.rspack-v2.pages.dev |
Contributor
|
📝 Benchmark detail: Open
|
35e2d12 to
5b6c4ea
Compare
chenjiahan
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.wasm cause unnecessay probe in resolver and vite and esbuild also doesnt support .wasm in extensions