Skip to content

feat!: change default value for devtool#12934

Merged
SyMind merged 4 commits intomainfrom
change-devtool-default-value
Feb 4, 2026
Merged

feat!: change default value for devtool#12934
SyMind merged 4 commits intomainfrom
change-devtool-default-value

Conversation

@SyMind
Copy link
Copy Markdown
Member

@SyMind SyMind commented Feb 4, 2026 •
edited
Loading

Summary

This PR updates the default devtool configuration for Rspack, aligning the core library defaults with CLI defaults and changing production mode behavior. The changes are marked as breaking with feat! in the PR title.

Changes:

  • Changed development mode default from 'eval' to 'cheap-module-source-map' in the core library (aligning with existing CLI default)
  • Changed production mode default from 'source-map' to false in the CLI (aligning with existing core library default)
  • Updated documentation to remove eval-based devtool options from development recommendations and reflect new production default

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SyMind SyMind requested a review from hardfist as a code owner February 4, 2026 02:31
Copilot AI review requested due to automatic review settings February 4, 2026 02:31
Copilot AI reviewed Feb 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 4, 2026 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -
react-1k 825.4 KB -
react-5k 2.7 MB -
ui-components 2.2 MB -
rome 984.2 KB -
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 825.4 KB - -
📄 JavaScript 825.4 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.2 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 267.8 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.2 KB - -
📄 JavaScript 984.2 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 4, 2026 •
edited
Loading

📦 Binary Size-limit

Comparing f6bef7f to chore(deps): update patch crates (#12929) by renovate[bot]

🙈 Size remains the same at 48.34MB

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 4, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing change-devtool-default-value (f6bef7f) with main (601bf3b)1

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark2

Footnotes

  1. No successful run was found on main (a79dab7) during the generation of this report, so 601bf3b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Feb 4, 2026

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0723b65
Status: ✅  Deploy successful!
Preview URL: https://64ee88b9.rspack-v2.pages.dev
Branch Preview URL: https://change-devtool-default-value.rspack-v2.pages.dev

View logs

@SyMind SyMind requested a review from Copilot February 4, 2026 05:50
chenjiahan
chenjiahan approved these changes Feb 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SyMind SyMind changed the title feat!: change default value for devtool in development feat!: change default value for devtool Feb 4, 2026
@SyMind SyMind merged commit 0f5a0bd into main Feb 4, 2026
108 of 113 checks passed
@SyMind SyMind deleted the change-devtool-default-value branch February 4, 2026 06:02
@SyMind SyMind review requested due to automatic review settings March 23, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chenjiahan chenjiahan chenjiahan approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SyMind @chenjiahan