chore: bump swc_core from 55 to 56 and swc-experimental from 0.4.1 to 0.5.0#12906
chore: bump swc_core from 55 to 56 and swc-experimental from 0.4.1 to 0.5.0#12906
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades SWC dependencies from version 55 to 56 for swc_core and from 0.4.1 to 0.5.0 for swc-experimental packages. The upgrade includes a refactoring of the identifier collection logic in concatenated_module.rs to use a visitor pattern instead of node array iteration, as the free_node API was temporarily removed from swc-experimental.
Changes:
- Upgraded swc_core and related packages (swc, swc_ecma_minifier, swc_html_minifier) to their latest versions
- Upgraded swc-experimental packages (swc_experimental_ecma_ast, swc_experimental_ecma_parser, swc_experimental_ecma_semantic) from 0.4.1 to 0.5.0
- Refactored
collect_identfunction to use the visitor pattern, porting logic fromutils::IdentCollector
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Updated version constraints for swc_core (55.0.0 → 56.0.0), swc (53.0.0 → 54.0.0), swc_ecma_minifier (43.0.0 → 44.0.0), swc_html_minifier (43.0.0 → 44.0.0), and swc-experimental packages (0.4.1 → 0.5.0) |
| crates/rspack_workspace/src/generated.rs | Updated the generated swc_core version string from "55.0.0" to "56.0.0" |
| crates/rspack_core/src/concatenated_module.rs | Refactored collect_ident to use visitor pattern; updated imports to include Visit, VisitWith, ObjectPatProp, and Prop; changed function signature to accept Module instead of Semantic |
| Cargo.lock | Comprehensive lockfile update reflecting all transitive dependency changes from the version bumps, including new dependencies like string-interner and swc_ecma_regexp family |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 5 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 react-10kPath:
📦 Download Diff Report: react-10k Bundle Diff 📁 react-1kPath:
📦 Download Diff Report: react-1k Bundle Diff 📁 react-5kPath:
📦 Download Diff Report: react-5k Bundle Diff 📁 romePath:
📦 Download Diff Report: rome Bundle Diff 📁 ui-componentsPath:
📦 Download Diff Report: ui-components Bundle Diff Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
❌ Size increased by 62.50KB from 48.31MB to 48.37MB (⬆️0.13%) |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Summary
SWC: https://github.com/swc-project/swc/blob/main/CHANGELOG-CORE.md
modulefeature swc-project/swc#11509). However, rspack depends on it to transform the typescript config files.SWC-experimental: https://github.com/CPunisher/swc-experimental/releases/tag/v0.5.0
free_node.Checklist