Skip to content

fix(mf): use dynamic exports type for MF modules (cherry-pick #12841)#12848

Merged
ahabhgk merged 1 commit intov1.xfrom
cherry-pick-12841-to-v1.x
Jan 26, 2026
Merged

fix(mf): use dynamic exports type for MF modules (cherry-pick #12841)#12848
ahabhgk merged 1 commit intov1.xfrom
cherry-pick-12841-to-v1.x

Conversation

@ahabhgk
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk commented Jan 26, 2026

Cherry-pick of #12841 to v1.x branch.

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Jan 26, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Jan 26, 2026

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: 27fa511
Status: ✅  Deploy successful!
Preview URL: https://bceba97c.rspack-v2.pages.dev
Branch Preview URL: https://cherry-pick-12841-to-v1-x.rspack-v2.pages.dev

View logs

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 26, 2026

📦 Binary Size-limit

Comparing 27fa511 to fix(mf): use dynamic exports type for MF modules (#12841) by Gengkun

🎉 Size decreased by 333.25KB from 48.33MB to 48.01MB (⬇️0.67%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 26, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing cherry-pick-12841-to-v1.x (27fa511) with main (b726ec5)1

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark2

Footnotes

  1. No successful run was found on v1.x (ebdfb97) during the generation of this report, so main (b726ec5) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@ahabhgk ahabhgk enabled auto-merge (squash) January 26, 2026 10:50
@ahabhgk ahabhgk merged commit b37b77a into v1.x Jan 26, 2026
52 of 53 checks passed
@ahabhgk ahabhgk deleted the cherry-pick-12841-to-v1.x branch January 26, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahabhgk @LingyuCoder