Skip to content

feat: keep unknown import.meta properties#12796

Merged
ahabhgk merged 4 commits intoweb-infra-dev:mainfrom
intellild:import_meta_preseve_unknown
Mar 2, 2026
Merged

feat: keep unknown import.meta properties#12796
ahabhgk merged 4 commits intoweb-infra-dev:mainfrom
intellild:import_meta_preseve_unknown

Conversation

@intellild
Copy link
Copy Markdown
Contributor

@intellild intellild commented Jan 20, 2026 •
edited
Loading

Summary

Unknown import.meta properties are now determined at runtime instead of being statically analyzed at compile time.

Related links

webpack/webpack#20312

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 20, 2026 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 435bd3e
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6970da1c68b4050008db202e

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jan 20, 2026
@intellild
Copy link
Copy Markdown
Contributor Author

intellild commented Jan 20, 2026

Hit compile and a lot of changes in wasi related files. Are these expected ?

@intellild intellild marked this pull request as ready for review January 20, 2026 14:35
@intellild intellild requested a review from hardfist as a code owner January 20, 2026 14:35
@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Jan 21, 2026

Hit compile and a lot of changes in wasi related files. Are these expected ?

@CPunisher cc

@CPunisher
Copy link
Copy Markdown
Contributor

CPunisher commented Jan 21, 2026

This is a bug of napi cli, which sometimes cannot generate exports well. Just revert the rspack.wasi-browser.js and rspack.wasi.cjs

@chenjiahan chenjiahan mentioned this pull request Jan 21, 2026
Merged
2 tasks
@intellild intellild requested a review from h-a-n-a as a code owner January 21, 2026 13:22
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 21, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing intellild:import_meta_preseve_unknown (f0a9116) with main (7da4bdc)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@intellild intellild force-pushed the import_meta_preseve_unknown branch from 435bd3e to 9093e21 Compare January 22, 2026 12:50
chenjiahan
chenjiahan reviewed Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you update the documentation too?

https://rspack.rs/config/module#moduleparserjavascriptimportmeta

@intellild
Copy link
Copy Markdown
Contributor Author

intellild commented Jan 30, 2026

I will update the document

@intellild intellild force-pushed the import_meta_preseve_unknown branch 3 times, most recently from cfbef9d to 817bcc8 Compare February 1, 2026 14:01
@intellild intellild force-pushed the import_meta_preseve_unknown branch 3 times, most recently from 6a5fa75 to 99b03a3 Compare February 15, 2026 10:22
@intellild intellild force-pushed the import_meta_preseve_unknown branch from 99b03a3 to 1950541 Compare February 24, 2026 12:59
chenjiahan
chenjiahan reviewed Feb 25, 2026
View reviewed changes
chenjiahan
chenjiahan reviewed Feb 25, 2026
View reviewed changes
ahabhgk
ahabhgk reviewed Feb 25, 2026
View reviewed changes
@intellild intellild force-pushed the import_meta_preseve_unknown branch from 9e4434a to 49c615f Compare February 27, 2026 14:36
@intellild
squash commits
874a1f4 
� Conflicts:
�	crates/rspack_plugin_javascript/src/parser_plugin/import_meta_plugin.rs
�	crates/rspack_plugin_javascript/src/visitors/dependency/parser/mod.rs
@intellild intellild force-pushed the import_meta_preseve_unknown branch from 49c615f to 874a1f4 Compare February 27, 2026 14:44
intellild and others added 3 commits February 27, 2026 22:51
ahabhgk
ahabhgk approved these changes Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahabhgk ahabhgk merged commit 27c8fbf into web-infra-dev:main Mar 2, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan left review comments

@ahabhgk ahabhgk ahabhgk approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

@stormslowly stormslowly Awaiting requested review from stormslowly

@quininer quininer Awaiting requested review from quininer

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@intellild @chenjiahan @CPunisher @ahabhgk