Skip to content

feat!: Rspack off modules and assets in normal stats#12701

Merged
SyMind merged 13 commits intov2from
change-stats-default-value
Jan 16, 2026
Merged

feat!: Rspack off modules and assets in normal stats#12701
SyMind merged 13 commits intov2from
change-stats-default-value

Conversation

@SyMind
Copy link
Copy Markdown
Member

@SyMind SyMind commented Jan 12, 2026 •
edited
Loading

Summary

This PR changes the default values for stats.modules and stats.chunks from true to false (unless all === true) to reduce JS-Rust communication overhead. This is a breaking change that diverges from webpack's default behavior.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 12, 2026 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit a74aaa7
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6964a043f1bd490008c0f4d4

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 12, 2026
@SyMind SyMind force-pushed the change-stats-default-value branch from 733c589 to a74aaa7 Compare January 12, 2026 07:18
@SyMind SyMind marked this pull request as ready for review January 12, 2026 07:21
@SyMind SyMind requested a review from hardfist as a code owner January 12, 2026 07:21
Copilot AI review requested due to automatic review settings January 12, 2026 07:21
Copilot AI reviewed Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the default values for stats.modules and stats.chunkModules from true to false (unless all === true) to reduce JS-Rust communication overhead. This is a breaking change that diverges from webpack's default behavior.

Changes:

  • Simplified chunkModules default from a complex conditional function to NORMAL_OFF
  • Simplified modules default from a complex conditional function to NORMAL_OFF
  • Added explanatory comments noting the divergence from webpack's defaults

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2026 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 3 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -8.0 B (-0.0%)
react-1k 825.4 KB 0
react-5k 2.7 MB +1.0 B (0.0%)
rome 985.8 KB +1.7 KB (0.2%)
ui-components 2.1 MB 0
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: fe1e14c1d5 | PR: #12763

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -8.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -8.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: fe1e14c1d5 | PR: #12763

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB +1.0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB +1.0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: fe1e14c1d5 | PR: #12763

Metric Current Baseline Change
📊 Total Size 985.8 KB 984.2 KB +1.7 KB (0.2%)
📄 JavaScript 985.8 KB 984.2 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2026 •
edited
Loading

📦 Binary Size-limit

Comparing bc6b59e to chore: limit threads for codspeed benchmark (#12763) by CPunisher

🎉 Size decreased by 343.38KB from 47.99MB to 47.66MB (⬇️0.70%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 12, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Comparing change-stats-default-value (bc6b59e) with v2 (a0a802b)2

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

  2. No successful run was found on v2 (f3c661a) during the generation of this report, so a0a802b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@SyMind SyMind marked this pull request as draft January 12, 2026 07:36
@SyMind SyMind changed the base branch from main to v2 January 13, 2026 09:27
@SyMind SyMind force-pushed the change-stats-default-value branch from a74aaa7 to 009656b Compare January 13, 2026 09:30
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 13, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 ready!

Name Link
🔨 Latest commit bc6b59e
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/696a05acaa48710008328ff5
😎 Deploy Preview https://deploy-preview-12701--rspack-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@SyMind SyMind force-pushed the change-stats-default-value branch from ea7de1c to 009656b Compare January 13, 2026 10:32
@SyMind SyMind changed the title feat!: Rspack disables modules by default in stats feat!: Rspack off modules and assets in normal stats Jan 15, 2026
@SyMind SyMind force-pushed the change-stats-default-value branch from d8e2e8b to bbddae3 Compare January 15, 2026 02:34
@SyMind SyMind force-pushed the change-stats-default-value branch from bbddae3 to 21c58bb Compare January 15, 2026 02:51
@SyMind SyMind marked this pull request as ready for review January 15, 2026 02:51
@SyMind SyMind force-pushed the change-stats-default-value branch from 47661e3 to 72d8a67 Compare January 15, 2026 03:43
@SyMind SyMind requested a review from LingyuCoder as a code owner January 15, 2026 03:49
@SyMind SyMind force-pushed the change-stats-default-value branch from 6869e51 to 7cbe5eb Compare January 15, 2026 03:59
@SyMind SyMind force-pushed the change-stats-default-value branch from 38ee695 to 0f1f048 Compare January 15, 2026 08:13
@SyMind SyMind force-pushed the change-stats-default-value branch from 0f1f048 to 28f2ed7 Compare January 15, 2026 08:44
@SyMind SyMind force-pushed the change-stats-default-value branch from a4587f7 to c495835 Compare January 15, 2026 08:53
@SyMind SyMind merged commit defdcd9 into v2 Jan 16, 2026
78 of 80 checks passed
@SyMind SyMind deleted the change-stats-default-value branch January 16, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@LingyuCoder LingyuCoder LingyuCoder approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SyMind @LingyuCoder