Skip to content

feat!: disable .swcrc reading in JavaScript compiler#12661

Closed
CPunisher wants to merge 6 commits intomainfrom
01-07-feat-2/disable-swcrc
Closed

feat!: disable .swcrc reading in JavaScript compiler#12661
CPunisher wants to merge 6 commits intomainfrom
01-07-feat-2/disable-swcrc

Conversation

@CPunisher
Copy link
Copy Markdown
Contributor

@CPunisher CPunisher commented Jan 7, 2026 •
edited
Loading

Summary

This PR removes the logic for searching, loading, and parsing .swcrc files within the JavaScriptCompiler.

Related links

None

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 7, 2026 10:35
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 7, 2026 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit c5ee1f6
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/695e592dff334b000896d5c2

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 7, 2026
@CPunisher CPunisher changed the title feat: disable swcrc reading in JavaScript compiler feat!: disable swcrc reading in JavaScript compiler Jan 7, 2026
@CPunisher CPunisher changed the title feat!: disable swcrc reading in JavaScript compiler feat!: disable .swcrc reading in JavaScript compiler Jan 7, 2026
Copilot AI reviewed Jan 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the JavaScript compiler by removing the logic for loading and parsing .swcrc configuration files. Instead, the compiler now expects the caller to provide fully populated SwcOptions, centralizing configuration handling and eliminating redundant file system operations.

  • Removed four helper functions related to .swcrc file discovery, loading, and parsing
  • Eliminated the config field from JavaScriptTransformer struct and updated all references
  • Added Rust formatter configuration to VS Code settings

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

File Description
crates/rspack_javascript_compiler/src/compiler/transform.rs Removed .swcrc configuration loading logic, cleaned up imports, simplified JavaScriptTransformer struct, and updated references from self.config to self.options.config
.vscode/settings.json Added default Rust formatter configuration for better developer experience

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 7, 2026 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -
react-1k 825.4 KB -
react-5k 2.7 MB -
rome 984.3 KB -
ui-components 2.1 MB -
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 825.4 KB - -
📄 JavaScript 825.4 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.3 KB - -
📄 JavaScript 984.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 7, 2026 •
edited
Loading

📦 Binary Size-limit

Comparing c5ee1f6 to refactor: afterCodeGeneration hook use read only compilation ref (#12655) by pshu

🎉 Size decreased by 327.63KB from 47.87MB to 47.55MB (⬇️0.67%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 7, 2026 •
edited
Loading

Merging this PR will not alter performance

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Comparing 01-07-feat-2/disable-swcrc (c5ee1f6) with main (25a4021)2

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

  2. No successful run was found on main (86634a0) during the generation of this report, so 25a4021 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@CPunisher CPunisher requested a review from quininer as a code owner January 7, 2026 12:53
@CPunisher CPunisher force-pushed the 01-07-feat-2/disable-swcrc branch from 2fc9077 to c5ee1f6 Compare January 7, 2026 13:01
@CPunisher CPunisher requested a review from hardfist January 8, 2026 03:24
@CPunisher CPunisher closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@hardfist hardfist hardfist approved these changes

@quininer quininer Awaiting requested review from quininer

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CPunisher @hardfist