Skip to content

[Bug]: HMR fails with RSPack v0.7.1 #6740

@markmssd

Description

@markmssd

System Info

MacOS 14.4.1

Details

With RSPack v0.7.1, HMR seems to have issues. Here is the stack trace:

app1 start: Panic occurred at runtime. Please file an issue on GitHub with the backtrace below: https://github.com/web-infra-dev/rspack/issues
app1 start: Message:  should have module graph module
app1 start: Location: crates/rspack_core/src/module_graph/mod.rs:563
app1 start: Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
app1 start: Run with RUST_BACKTRACE=full to include source snippets.
app1 start: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
app1 start:  1: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start:  2: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start:  3: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start:  4: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start:  5: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start:  6: _wasmer_vm_imported_memory32_atomic_notify
app1 start:     at <unknown source file>
app1 start:  7: _wasmer_vm_imported_memory32_atomic_notify
app1 start:     at <unknown source file>
app1 start:  8: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start:  9: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start: 10: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start: 11: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start: 12: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start: 13: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start: 14: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start: 15: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start: 16: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start: 17: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start: 18: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start: 19: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start: 20: _napi_register_module_v1
app1 start:     at <unknown source file>
app1 start: 21: __pthread_joiner_wake
app1 start:     at <unknown source file>
Screenshot 2024-06-05 at 1 43 00 PM

I have included a reproducible. It is based on https://github.com/module-federation/module-federation-examples/tree/master/advanced-api/dynamic-remotes, but with upgraded RSPack.

Note that with v0.7.0, HMR worked without problem.

Reproduce link

https://github.com/markmssd/module-federation-runtime-shared/tree/rspack-0.7.1

Reproduce Steps

git clone https://github.com/markmssd/module-federation-runtime-shared/tree/rspack-0.7.1
cd  module-federation-runtime-shared
pnpm install
pnpm start

// everything works so far.
// edit any file, e.g. `app1/src/App.js`, to trigger HMR
// it crashes 💥

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions