perf: remove unnecessary async_trait usage (#14041)

hardfist · codspeed-hq[bot] · web-flow · commit c050e8fdb43e · 2026-05-20T16:46:58.000+08:00
* perf: remove unnecessary async_trait usage

* perf: keep async_trait for compilation passes

* perf: restore impl Future for PassExt with boxed run_pass future

* perf: keep async_trait on PassExt to preserve cache locality

---------

Co-authored-by: codspeed-hq[bot] &lt;117304815+codspeed-hq[bot]@users.noreply.github.com&gt;
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/rspack_binding_api/src/raw_options/raw_builtins/raw_lazy_compilation.rs b/crates/rspack_binding_api/src/raw_options/raw_builtins/raw_lazy_compilation.rs
@@ -42,7 +42,6 @@ pub struct LazyCompilationTestFn {
   tsfn: ThreadsafeFunction<ModuleObject, Option<bool>>,
 }
 
-#[async_trait::async_trait]
 impl LazyCompilationTestCheck for LazyCompilationTestFn {
   async fn test(
     &self,
@@ -112,7 +111,6 @@ impl From<&RawLazyCompilationOption> for JsBackend {
   }
 }
 
-#[async_trait::async_trait]
 impl Backend for JsBackend {
   async fn current_active_modules(&mut self) -> rspack_error::Result<IdentifierSet> {
     let active_modules = self
diff --git a/crates/rspack_core/src/cache/persistent/occasion/make/mod.rs b/crates/rspack_core/src/cache/persistent/occasion/make/mod.rs
@@ -30,7 +30,6 @@ impl MakeOccasion {
   }
 }
 
-#[async_trait::async_trait]
 impl Occasion for MakeOccasion {
   type Artifact = BuildModuleGraphArtifact;
 
diff --git a/crates/rspack_core/src/cache/persistent/occasion/meta/mod.rs b/crates/rspack_core/src/cache/persistent/occasion/meta/mod.rs
@@ -29,7 +29,6 @@ impl MetaOccasion {
   }
 }
 
-#[async_trait::async_trait]
 impl Occasion for MetaOccasion {
   /// Meta has no structured artifact: it reads/writes a single global counter.
   type Artifact = ();
diff --git a/crates/rspack_core/src/cache/persistent/occasion/minimize/mod.rs b/crates/rspack_core/src/cache/persistent/occasion/minimize/mod.rs
@@ -88,7 +88,6 @@ impl MinimizeOccasion {
   }
 }
 
-#[async_trait::async_trait]
 impl Occasion for MinimizeOccasion {
   type Artifact = MinimizePersistentCacheArtifact;
 
diff --git a/crates/rspack_core/src/cache/persistent/occasion/mod.rs b/crates/rspack_core/src/cache/persistent/occasion/mod.rs
@@ -2,6 +2,8 @@ pub mod make;
 pub mod meta;
 pub mod minimize;
 
+use std::future::Future;
+
 pub use make::MakeOccasion;
 pub use meta::MetaOccasion;
 pub use minimize::{
@@ -20,7 +22,6 @@ use super::storage::Storage;
 ///
 /// `BuildDeps` and `Snapshot` are not occasions: they operate across multiple
 /// scopes and have more complex lifecycle semantics.
-#[async_trait::async_trait]
 pub trait Occasion {
   /// The data produced/consumed by this occasion.
   type Artifact: Send;
@@ -35,5 +36,8 @@ pub trait Occasion {
   fn save(&self, storage: &mut dyn Storage, artifact: &Self::Artifact);
 
   /// Load and reconstruct the artifact from storage.
-  async fn recovery(&self, storage: &dyn Storage) -> Result<Self::Artifact>;
+  fn recovery<'a>(
+    &'a self,
+    storage: &'a dyn Storage,
+  ) -> impl Future<Output = Result<Self::Artifact>> + Send + 'a;
 }
diff --git a/crates/rspack_core/src/runtime_module.rs b/crates/rspack_core/src/runtime_module.rs
@@ -52,17 +52,14 @@ pub trait RuntimeModule:
   }
 }
 
-#[async_trait]
 pub trait AttachableRuntimeModule {
   fn attach(&mut self, chunk: ChunkUkey);
 }
 
-#[async_trait]
 pub trait NamedRuntimeModule {
   fn name(&self) -> Identifier;
 }
 
-#[async_trait]
 pub trait CustomSourceRuntimeModule {
   fn set_custom_source(&mut self, source: String);
   fn get_custom_source(&self) -> Option<String>;
diff --git a/crates/rspack_parallel/Cargo.toml b/crates/rspack_parallel/Cargo.toml
@@ -7,7 +7,6 @@ repository        = "https://github.com/web-infra-dev/rspack"
 version.workspace = true
 
 [dependencies]
-async-trait  = { workspace = true }
 rayon        = { workspace = true }
 rspack_tasks = { workspace = true }
 tokio        = { workspace = true, features = ["rt", "sync", "macros"] }
diff --git a/crates/rspack_parallel/src/iterator_consumer/future.rs b/crates/rspack_parallel/src/iterator_consumer/future.rs
@@ -4,7 +4,6 @@ use rspack_tasks::spawn_in_context;
 use tokio::sync::mpsc::unbounded_channel;
 
 /// Tools for consume iterator which return future.
-#[async_trait::async_trait]
 pub trait FutureConsumer {
   type Item;
   /// Use to immediately consume the data produced by the future in the iterator
@@ -13,7 +12,6 @@ pub trait FutureConsumer {
   fn fut_consume(self, func: impl FnMut(Self::Item) + Send) -> impl Future<Output = ()>;
 }
 
-#[async_trait::async_trait]
 impl<I, Fut> FutureConsumer for I
 where
   I: Iterator<Item = Fut>,
diff --git a/crates/rspack_plugin_lazy_compilation/src/backend.rs b/crates/rspack_plugin_lazy_compilation/src/backend.rs
@@ -1,7 +1,8 @@
+use std::future::Future;
+
 use rspack_collections::IdentifierSet;
 use rspack_error::Result;
 
-#[async_trait::async_trait]
 pub trait Backend: std::fmt::Debug + Send + Sync {
-  async fn current_active_modules(&mut self) -> Result<IdentifierSet>;
+  fn current_active_modules(&mut self) -> impl Future<Output = Result<IdentifierSet>> + Send + '_;
 }
diff --git a/crates/rspack_plugin_lazy_compilation/src/plugin.rs b/crates/rspack_plugin_lazy_compilation/src/plugin.rs
@@ -1,5 +1,6 @@
 use std::{
   fmt::Debug,
+  future::Future,
   sync::{Arc, LazyLock},
 };
 
@@ -33,14 +34,13 @@ pub enum LazyCompilationTest<F: LazyCompilationTestCheck> {
   Fn(F),
 }
 
-#[async_trait::async_trait]
 pub trait LazyCompilationTestCheck: Send + Sync + Debug {
-  async fn test(
-    &self,
+  fn test<'a>(
+    &'a self,
     compiler_id: CompilerId,
     compilation_id: CompilationId,
-    module: &dyn Module,
-  ) -> bool;
+    module: &'a dyn Module,
+  ) -> impl Future<Output = bool> + Send + 'a;
 }
 
 impl<F: LazyCompilationTestCheck> LazyCompilationTest<F> {

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,6 @@ pub struct LazyCompilationTestFn {`
`42`	`42`	`tsfn: ThreadsafeFunction<ModuleObject, Option<bool>>,`
`43`	`43`	`}`
`44`	`44`
`45`		`-#[async_trait::async_trait]`
`46`	`45`	`impl LazyCompilationTestCheck for LazyCompilationTestFn {`
`47`	`46`	`async fn test(`
`48`	`47`	`&self,`
`@@ -112,7 +111,6 @@ impl From<&RawLazyCompilationOption> for JsBackend {`
`112`	`111`	`}`
`113`	`112`	`}`
`114`	`113`
`115`		`-#[async_trait::async_trait]`
`116`	`114`	`impl Backend for JsBackend {`
`117`	`115`	`async fn current_active_modules(&mut self) -> rspack_error::Result<IdentifierSet> {`
`118`	`116`	`let active_modules = self`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ impl MakeOccasion {`
`30`	`30`	`}`
`31`	`31`	`}`
`32`	`32`
`33`		`-#[async_trait::async_trait]`
`34`	`33`	`impl Occasion for MakeOccasion {`
`35`	`34`	`type Artifact = BuildModuleGraphArtifact;`
`36`	`35`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@ impl MetaOccasion {`
`29`	`29`	`}`
`30`	`30`	`}`
`31`	`31`
`32`		`-#[async_trait::async_trait]`
`33`	`32`	`impl Occasion for MetaOccasion {`
`34`	`33`	`/// Meta has no structured artifact: it reads/writes a single global counter.`
`35`	`34`	`type Artifact = ();`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,6 @@ impl MinimizeOccasion {`
`88`	`88`	`}`
`89`	`89`	`}`
`90`	`90`
`91`		`-#[async_trait::async_trait]`
`92`	`91`	`impl Occasion for MinimizeOccasion {`
`93`	`92`	`type Artifact = MinimizePersistentCacheArtifact;`
`94`	`93`
Original file line number	Diff line number	Diff line change
`@@ -52,17 +52,14 @@ pub trait RuntimeModule:`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`
`55`		`-#[async_trait]`
`56`	`55`	`pub trait AttachableRuntimeModule {`
`57`	`56`	`fn attach(&mut self, chunk: ChunkUkey);`
`58`	`57`	`}`
`59`	`58`
`60`		`-#[async_trait]`
`61`	`59`	`pub trait NamedRuntimeModule {`
`62`	`60`	`fn name(&self) -> Identifier;`
`63`	`61`	`}`
`64`	`62`
`65`		`-#[async_trait]`
`66`	`63`	`pub trait CustomSourceRuntimeModule {`
`67`	`64`	`fn set_custom_source(&mut self, source: String);`
`68`	`65`	`fn get_custom_source(&self) -> Option<String>;`