feat(parser): disable requireAsExpression by default

LingyuCoder · chenjiahan · commit a345710f2a95 · 2026-01-20T13:42:47.000+08:00
Change the default value of `requireAsExpression` from `true` to `false`.
This reduces unnecessary warnings when using `require` as an expression
in most common use cases.
diff --git a/crates/rspack/src/builder/mod.rs b/crates/rspack/src/builder/mod.rs
@@ -1697,7 +1697,7 @@ impl ModuleOptionsBuilder {
           worker: Some(vec!["...".to_string()]),
           import_meta: Some(true),
           require_alias: Some(true),
-          require_as_expression: Some(true),
+          require_as_expression: Some(false),
           require_dynamic: Some(true),
           require_resolve: Some(true),
           commonjs: Some(JavascriptParserCommonjsOptions {
diff --git a/crates/rspack/tests/snapshots/defaults__default_options.snap b/crates/rspack/tests/snapshots/defaults__default_options.snap
@@ -1644,7 +1644,7 @@ CompilerOptions {
                                 true,
                             ),
                             require_as_expression: Some(
-                                true,
+                                false,
                             ),
                             require_dynamic: Some(
                                 true,
diff --git a/packages/rspack/src/config/defaults.ts b/packages/rspack/src/config/defaults.ts
@@ -263,7 +263,7 @@ const applyJavascriptParserOptionsDefaults = (
   D(parserOptions, 'wrappedContextCritical', false);
   D(parserOptions, 'wrappedContextRegExp', /.*/);
   D(parserOptions, 'strictExportPresence', false);
-  D(parserOptions, 'requireAsExpression', true);
+  D(parserOptions, 'requireAsExpression', false);
   D(parserOptions, 'requireAlias', false);
   D(parserOptions, 'requireDynamic', true);
   D(parserOptions, 'requireResolve', true);
diff --git a/tests/rspack-test/configCases/context-module/unknown-context-critical/rspack.config.js b/tests/rspack-test/configCases/context-module/unknown-context-critical/rspack.config.js
@@ -6,6 +6,7 @@ module.exports = {
 			javascript: {
 				unknownContextCritical: true,
 				requireAlias: true,
+				requireAsExpression: true
 			}
 		}
 	}
diff --git a/tests/rspack-test/configCases/parsing/rspack-issue-10005/rspack.config.js b/tests/rspack-test/configCases/parsing/rspack-issue-10005/rspack.config.js
@@ -4,6 +4,7 @@ module.exports = {
     parser: {
       javascript: {
         requireAlias: true,
+        requireAsExpression: true
       },
     }
   },
diff --git a/tests/rspack-test/defaultsCases/default/base.js b/tests/rspack-test/defaultsCases/default/base.js
@@ -256,7 +256,7 @@ module.exports = {
 			        importMeta: true,
 			        jsx: false,
 			        requireAlias: false,
-			        requireAsExpression: true,
+			        requireAsExpression: false,
 			        requireDynamic: true,
 			        requireResolve: true,
 			        strictExportPresence: false,
diff --git a/tests/rspack-test/diagnosticsCases/module-parse-failed/require-warning/rspack.config.js b/tests/rspack-test/diagnosticsCases/module-parse-failed/require-warning/rspack.config.js
@@ -4,6 +4,7 @@ module.exports = {
 		parser: {
 			javascript: {
 				requireAlias: true,
+				requireAsExpression: true
 			}
 		}
 	}
diff --git a/tests/rspack-test/normalCases/parsing/context/rspack.config.js b/tests/rspack-test/normalCases/parsing/context/rspack.config.js
@@ -0,0 +1,10 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	module: {
+		parser: {
+			javascript: {
+				requireAsExpression: true
+			}
+		}
+	}
+};
diff --git a/tests/rspack-test/normalCases/warnings/require-as-expression/rspack.config.js b/tests/rspack-test/normalCases/warnings/require-as-expression/rspack.config.js
@@ -0,0 +1,10 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	module: {
+		parser: {
+			javascript: {
+				requireAsExpression: true
+			}
+		}
+	}
+};
diff --git a/tests/rspack-test/statsOutputCases/async-commons-chunk/__snapshots__/stats.txt b/tests/rspack-test/statsOutputCases/async-commons-chunk/__snapshots__/stats.txt
@@ -7,18 +7,5 @@ chunk (runtime: main) 269.js xx bytes <{889}> ={267}= [rendered]
   ./c.js xx bytes [built] [code generated]
 chunk (runtime: main) main.js (main) xx bytes (javascript) xx KiB (runtime) >{267}< >{269}< [entry] [rendered]
   > ./ main
-  dependent modules xx bytes [dependent] 1 module
-  ./index.js xx bytes [built] [code generated] [1 warning]
-
-WARNING in ./index.js 9:2-8
-  ⚠ Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
-    ╭─[9:4]
-  7 │ 
-  8 │ it("should load a chunk with async commons (AMD)", () => new Promise(done => {
-  9 │     require(["./a", "./b"], (a, b) => {
-    ·     ───────
- 10 │         expect(a).toBe("a");
- 11 │         expect(b).toBe("b");
-    ╰────
-
-Rspack x.x.x compiled with 1 warning
+  ./index.js xx bytes [built] [code generated]
+Rspack x.x.x compiled successfully
diff --git a/website/docs/en/config/module.mdx b/website/docs/en/config/module.mdx
@@ -771,18 +771,18 @@ export default {
 
 ### module.parser.javascript.requireAsExpression
 
-<PropertyType type="boolean" defaultValueList={[{ defaultValue: 'true' }]} />
+<PropertyType type="boolean" defaultValueList={[{ defaultValue: 'false' }]} />
 
 Control whether `require` used as an expression will be parsed.
 
-When set to `false`, Rspack will not parse `require` when it's used as an expression (e.g., `const req = require; req('./module')`). This can improve build performance if your code doesn't use this pattern.
+When set to `true`, Rspack will parse `require` when it's used as an expression (e.g., `const req = require; req('./module')`) and emit a warning. When set to `false`, this pattern will be ignored.
 
 ```js title="rspack.config.mjs"
 export default {
   module: {
     parser: {
       javascript: {
-        requireAsExpression: false,
+        requireAsExpression: true,
       },
     },
   },
diff --git a/website/docs/zh/config/module.mdx b/website/docs/zh/config/module.mdx
@@ -771,18 +771,18 @@ export default {
 
 ### module.parser.javascript.requireAsExpression
 
-<PropertyType type="boolean" defaultValueList={[{ defaultValue: 'true' }]} />
+<PropertyType type="boolean" defaultValueList={[{ defaultValue: 'false' }]} />
 
 控制是否解析作为表达式使用的 `require`。
 
-当设置为 `false` 时，Rspack 不会解析作为表达式使用的 `require`（例如：`const req = require; req('./module')`）。如果代码中不使用这种模式，可以提高构建性能。
+当设置为 `true` 时，Rspack 会解析作为表达式使用的 `require`（例如：`const req = require; req('./module')`）并发出警告。当设置为 `false` 时，这种模式会被忽略。
 
 ```js title="rspack.config.mjs"
 export default {
   module: {
     parser: {
       javascript: {
-        requireAsExpression: false,
+        requireAsExpression: true,
       },
     },
   },

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ module.exports = {`
`6`	`6`	`javascript: {`
`7`	`7`	`unknownContextCritical: true,`
`8`	`8`	`requireAlias: true,`
	`9`	`+ requireAsExpression: true`
`9`	`10`	`}`
`10`	`11`	`}`
`11`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ module.exports = {`
`4`	`4`	`parser: {`
`5`	`5`	`javascript: {`
`6`	`6`	`requireAlias: true,`
	`7`	`+ requireAsExpression: true`
`7`	`8`	`},`
`8`	`9`	`}`
`9`	`10`	`},`