fix: handle re-export alias false positives in no-undef rule#573
Merged
chenjiahan merged 1 commit intomainfrom Mar 27, 2026
Merged
fix: handle re-export alias false positives in no-undef rule#573chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the no_undef rule to correctly handle re-export aliases, ensuring that the original name in export { Original as Alias } from 'module' statements is skipped. It introduces an isReExport helper function and adds test cases for both valid re-exports and invalid local exports. A suggestion was provided to refactor the isReExport function to improve conciseness and readability by combining parent node nil-checks.
chenjiahan
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix false positives in
no-undefrule for re-export aliases:export { X as Y } from 'module'— the original nameXis the source module's export name, not a local reference, but was incorrectly reported as "not defined"export type { X as Y } from 'module'— same issue with type-only re-exportsThe fix skips
ExportSpecifier.propertyNamewhen the parentExportDeclarationhas amoduleSpecifier(i.e., afromclause). Local export aliases (export { X as Y }withoutfrom) are unaffected —Xis correctly checked as a local reference.Related Links
Checklist