Skip to content

fix: normalize glob patterns for consistent file matching#550

Merged
fansenze merged 1 commit intomainfrom
fix/normalize-pattern-dotslash-20260319
Mar 20, 2026
Merged

fix: normalize glob patterns for consistent file matching#550
fansenze merged 1 commit intomainfrom
fix/normalize-pattern-dotslash-20260319

Conversation

@fansenze
Copy link
Copy Markdown
Contributor

@fansenze fansenze commented Mar 19, 2026 •
edited
Loading

Summary

  • Config files/ignores patterns with relative path segments (e.g., "./src/foo.ts", "src/./utils/*.ts", "src/../lib/*.ts") failed to match normalized file paths because normalizePath strips ./, collapses /./, and resolves .., but patterns were passed to doublestar.Match as-is.
  • Added normalizePattern() using tspath.NormalizePath to apply the same path cleanup to glob patterns before matching.
  • Fixed all three matching functions: isFileMatched, isFileIgnored, and isFileIgnoredSimple.

Related Links

N/A

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@gemini-code-assist
Copy link
Copy Markdown

gemini-code-assist bot commented Mar 19, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inconsistency in how glob patterns were matched against normalized file paths. Previously, patterns containing leading ./ or mid-path /./ would not correctly match files because the file paths themselves were normalized by stripping these elements, while the patterns were not. The changes introduce a pattern normalization step, ensuring that both patterns and file paths undergo similar transformations before matching, thereby improving the reliability and consistency of file inclusion and exclusion rules.

Highlights

  • Consistent Glob Pattern Matching: Implemented a normalizePattern() helper function to preprocess glob patterns, ensuring they are consistent with how file paths are normalized. This resolves issues where patterns with ./ prefixes or /./ mid-path failed to match correctly.
  • Wider Application of Pattern Normalization: The new normalizePattern() helper has been integrated into all three file matching functions: isFileMatched, isFileIgnored, and isFileIgnoredSimple, ensuring uniform behavior across the configuration system.
  • Enhanced Test Coverage: Added new test cases to cwd_test.go specifically to validate the correct matching of glob patterns containing ./ prefixes and /./ segments, confirming the fix for previously failing scenarios.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly identifies a bug where glob patterns with a ./ prefix were not matching file paths as expected. The introduction of the normalizePattern function is the right approach. However, the current implementation of normalizePattern is incomplete as it doesn't handle .. path segments, which could lead to continued incorrect matching. I've provided a critical suggestion to use tspath.NormalizePath for a more robust and correct implementation. Additionally, I've included a medium-severity suggestion to improve performance by normalizing patterns only once when the configuration is loaded. Finally, I've suggested adding a test case to cover the .. scenario once normalizePattern is updated.

@fansenze
fix: normalize glob patterns for consistent file matching
7de15e1 
Config patterns like "./src/foo.ts" failed to match normalized file paths
"src/foo.ts" because normalizePath strips leading "./", mid-path "/./",
and resolves ".." segments, but patterns were passed to doublestar.Match
as-is. Add normalizePattern() using tspath.NormalizePath to apply the same
cleanup to patterns in isFileMatched, isFileIgnored, and isFileIgnoredSimple.
@fansenze fansenze changed the title fix: normalize glob patterns to strip './' prefix for consistent file matching fix: normalize glob patterns for consistent file matching Mar 19, 2026
@fansenze fansenze force-pushed the fix/normalize-pattern-dotslash-20260319 branch from 74b869c to 7de15e1 Compare March 19, 2026 11:08
@fansenze fansenze requested a review from hardfist March 19, 2026 11:09
@fansenze fansenze merged commit 7e1d008 into main Mar 20, 2026
14 checks passed
@fansenze fansenze deleted the fix/normalize-pattern-dotslash-20260319 branch March 20, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hardfist hardfist hardfist approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fansenze @hardfist