fix: add build step for @rslint/core dist in release CI#543
Merged
Conversation
The publish-npm job was missing the build:js step, causing the dist/ directory to be absent from the published @rslint/core package. The Go binaries were correctly built and moved, but the TypeScript source was never compiled to JavaScript before publishing.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
chenjiahan
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
publish-npmjob in the release CI was missing abuild:jsstep for@rslint/core. The Go binaries (rslint, tsgo) were correctly built and moved via artifacts, but the TypeScript source files were never compiled to JavaScript, causing thedist/directory to be absent from the published npm package.This adds
pnpm --filter @rslint/core build:jsbetween the "Move binaries" and "Publish npm packages" steps. Thetsgobinary is already available at this point (via downloaded artifacts moved tonpm/tsgo/{platform}/lib/), so the build succeeds normally.Related Links
N/A
Checklist