Skip to content

fix(website): dark mode ui#487

Merged
fansenze merged 5 commits intoweb-infra-dev:mainfrom
eryue0220:fix/rslin-playground-dark-mode-ui
Mar 3, 2026
Merged

fix(website): dark mode ui#487
fansenze merged 5 commits intoweb-infra-dev:mainfrom
eryue0220:fix/rslin-playground-dark-mode-ui

Conversation

@eryue0220
Copy link
Copy Markdown
Contributor

@eryue0220 eryue0220 commented Feb 24, 2026

Summary

  • Fix playground dark mode ui
  • Fix error when running pnpm dev
  • Update website Readme
image

Updated:

image

Related Links

No

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@gemini-code-assist
Copy link
Copy Markdown

gemini-code-assist bot commented Feb 24, 2026

Summary of Changes

Hello @eryue0220, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the website's development setup and user interface. It addresses critical issues preventing the pnpm dev command from running correctly and improves the visual presentation of the Playground component, particularly in dark mode, by adjusting styling and ensuring proper asset resolution. These changes collectively streamline the development workflow and refine the user experience.

Highlights

  • Playground Dark Mode UI: Fixed visual issues in the Playground's dark mode user interface, ensuring better readability and consistency.
  • Development Environment Fix: Resolved an error that occurred when running pnpm dev, improving the local development experience.
  • Website README Update: Updated the website README with essential instructions for building the @rslint/wasm package.
Changelog
  • website/README.md
    • Added instructions for building the @rslint/wasm package, which is required for the Playground.
    • Included a note specifying that the wasm build step requires Go to be installed.
  • website/rspress.config.ts
    • Introduced resolve.alias configurations within builderConfig to correctly map @rslint/wasm and its rslint.wasm.gz file to their respective package paths.
  • website/theme/components/Playground/EditorTabs.tsx
    • Applied dark:text-accent dark:border-muted/20 CSS classes to the editor tabs for improved dark mode styling.
  • website/theme/components/Playground/ResultPanel.css
    • Set specific color values for .diagnostic-header and .diagnostic-message to ensure better text visibility in dark mode.
  • website/theme/components/Playground/ResultPanel.tsx
    • Added dark:text-accent dark:border-muted/20 CSS classes to the result panel tabs ('Errors', 'AST (tsgo)', 'AST (TypeScript)') for consistent dark mode appearance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request effectively addresses dark mode UI issues within the playground and updates the README.md with necessary build instructions for the WASM module. The rspress.config.ts changes correctly configure aliases for the WASM package, which is crucial for the playground's functionality. Styling updates in EditorTabs.tsx and ResultPanel.tsx appropriately leverage Tailwind CSS dark: variants for better dark mode integration. However, the direct use of hardcoded hex color values in ResultPanel.css for text color might not fully align with a comprehensive dark mode strategy that relies on Tailwind's utility classes or CSS variables, potentially leading to inconsistencies.

fansenze
fansenze reviewed Mar 2, 2026
View reviewed changes
fansenze
fansenze reviewed Mar 2, 2026
View reviewed changes
@fansenze
Copy link
Copy Markdown
Contributor

fansenze commented Mar 2, 2026

@eryue0220 Thanks for the PR! Just two small nits left inline to address before we merge.

@fansenze fansenze enabled auto-merge (squash) March 3, 2026 03:53
@fansenze fansenze merged commit 58e019e into web-infra-dev:main Mar 3, 2026
10 checks passed
@eryue0220 eryue0220 deleted the fix/rslin-playground-dark-mode-ui branch March 3, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fansenze fansenze fansenze approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eryue0220 @fansenze