chore: update typescript-go submodule by fansenze · Pull Request #454 · web-infra-dev/rslint

fansenze · 2026-02-03T09:35:49Z

Summary

Update typescript-go submodule to commit 1d68dfd4db394ed9d19b812d46c1368daa2e8893 from rstackjs/typescript-go llts branch.

Key Changes

Shim Layer Updates:

shim/checker/shim.go: Fix extra_Checker struct field layout to match new Checker structure (added moduleSymbols and propertiesTypes fields, updated map key types)
shim/scanner/shim.go: Change GetECMAPositionOfLineAndCharacter from linkname to wrapper function with correct interface type
shim/lsp/lsproto/shim.go: Add LSPError compatibility struct, update error variables, fix RegisterOptions union type
shim/ast/shim.go: Remove undefined constants, update GetAssertedTypeNode
shim/core/shim.go: Update WithLocale linkname target to locale package
shim/tsoptions/shim.go: Add optionsRaw parameter to GetParsedCommandLineOfConfigFile
shim/project/shim.go: Update NewSnapshot signature and imports

Main Repository Updates:

cmd/tsgo/main.go: Change diag.Message() to diag.String()
cmd/rslint/cmd.go: Add nil guards for SourceFile and lineMap
internal/lsp/server.go: Add PublishDiagnostics, RefreshInlayHints, RefreshCodeLens methods for project.Client interface; pass BackgroundCtx to NewSession
internal/utils/create_program.go: Update diagnostic method and add optionsRaw parameter
internal/utils/ts_api_utils.go: Add TokenFlagsNone parameter to GetOrCreateToken calls

New:

agents/debug-ci/SKILL.md: Add skill document for reproducing CI failures locally using Docker, covering all CI jobs with references to actual CI config files

Checklist

Tests updated (or not required).
Documentation updated (or not required).

gemini-code-assist · 2026-02-03T09:36:22Z

Summary of Changes

Hello @fansenze, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on synchronizing the project with the latest upstream changes from the typescript-go submodule. This update is crucial for maintaining compatibility and incorporating new features and bug fixes from the core TypeScript-Go implementation. The changes span across various shim layers and parts of the main repository, ensuring that the project correctly interfaces with the updated submodule and adheres to the latest API specifications.

Highlights

Submodule Update: The typescript-go submodule has been updated to commit 1d68dfd4db394ed9d19b812d46c1368daa2e8893, bringing in the latest changes from the upstream rstackjs/typescript-go project's llts branch.
Shim Layer Adjustments: Several shim files (shim/checker/shim.go, shim/scanner/shim.go, shim/lsp/lsproto/shim.go, shim/ast/shim.go, shim/core/shim.go, shim/tsoptions/shim.go, shim/project/shim.go) have been updated to align with the new typescript-go structure and API changes, including fixes for struct field layouts, function signatures, and constant definitions.
Main Repository Adaptations: Changes in the main repository include adding nil guards in cmd/rslint/cmd.go, updating diagnostic message methods from Message() to String() in cmd/tsgo/main.go and internal/utils/create_program.go, and implementing new LSP client methods in internal/lsp/server.go.
LSP Protocol Compatibility: The shim/lsp/lsproto/shim.go file introduces an LSPError compatibility struct and updates error variables and constant names to match recent LSP protocol changes, ensuring continued interoperability.

Changelog

cmd/rslint/cmd.go
- Added nil guards for SourceFile and lineMap in printDiagnosticDefault to prevent panics.
cmd/tsgo/main.go
- Changed diag.Message() to diag.String() for diagnostic message retrieval.
internal/lsp/server.go
- Updated RegisterOptions for DidChangeWatchedFilesRegistrationOptions to use a structured type instead of any.
- Added new methods PublishDiagnostics, RefreshInlayHints, and RefreshCodeLens to implement the project.Client interface.
- Modified error handling in sendError to use the new lsproto.LSPError type for better compatibility.
internal/utils/create_program.go
- Updated the GetParsedCommandLineOfConfigFile call to include a new optionsRaw parameter.
- Changed diagnostic message retrieval from diagnostic.Message() to diagnostic.String().
internal/utils/ts_api_utils.go
- Added ast.TokenFlagsNone as a new parameter to sourceFile.GetOrCreateToken calls.
shim/ast/shim.go
- Converted GetAssertedTypeNode from a linkname to a compatibility wrapper function.
- Removed undefined constants JSDeclarationKindPrototypeProperty and KindBundle.
shim/checker/shim.go
- Updated the extra_Checker struct by changing map key types from string to checker.CacheHashKey for indexedAccessTypes, templateLiteralTypes, subtypeReductionCache, errorTypes, tupleTypes, unionTypes, and intersectionTypes.
- Added new fields moduleSymbols and propertiesTypes to the extra_Checker struct.
- Changed SignatureKeyBase and related SignatureKey constants from const to var.
shim/core/shim.go
- Updated the WithLocale linkname target to point to github.com/microsoft/typescript-go/internal/locale.WithLocale.
shim/lsp/lsproto/shim.go
- Removed CodeLenssOrNull, InitializeParamsBase, LSPErrorCodes, SemanticTokenModifiers, and SemanticTokenTypes types/constants.
- Introduced a custom LSPError struct for compatibility and updated error variables (ErrContentModified, ErrInternalError, etc.) to use this new type.
- Updated ErrorCodes constants to map to the new lsproto.ErrorCode values.
- Renamed several constants (e.g., FileOperationPatternKindfile to FileOperationPatternKindFile, InsertTextModeadjustIndentation to InsertTextModeAdjustIndentation, MonikerKindexport to MonikerKindExport, UniquenessLeveldocument to UniquenessLevelDocument) to reflect upstream naming conventions.
- Converted NewRequestMessage from a linkname to a wrapper function.
- Added RegisterOptions type.
shim/project/shim.go
- Added imports for lsutil and autoimport packages.
- Removed Config and ParseCacheOptions types.
- Updated the NewSnapshot function signature to reflect changes in its parameters, including the removal of parseCache, extendedConfigCache, and config, and the addition of allUserPreferences, autoImports, and autoImportsWatch.
shim/scanner/shim.go
- Converted GetECMAPositionOfLineAndCharacter from a linkname to a wrapper function, now accepting ast.SourceFileLike.
shim/tsoptions/shim.go
- Added import for the collections package.
- Updated GetParsedCommandLineOfConfigFile and GetParsedCommandLineOfConfigFilePath signatures to include a new optionsRaw parameter.
typescript-go
- Updated the submodule commit from c3dbd169b1ae2cf30086a0b38df15b4c18ec9c62 to 1d68dfd4db394ed9d19b812d46c1368daa2e8893.

Activity

The pull request description indicates that tests have been updated (or not required) and documentation has been updated (or not required).
No other human activity such as comments or reviews is mentioned in the provided context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the typescript-go submodule and adapts the codebase to the new API. The changes are mostly in the shim packages and files that use the typescript-go API. The changes look correct and handle the API updates properly. I've added one suggestion to improve maintainability by reducing code duplication in cmd/rslint/cmd.go.

cmd/rslint/cmd.go

Update typescript-go submodule to commit 1d68dfd4db394ed9d19b812d46c1368daa2e8893 from rstackjs/typescript-go llts branch. Changes: - Update shim layer to adapt to API changes in typescript-go - Fix extra_Checker struct field layout to match new Checker structure - Update function signatures and type aliases for compatibility - Add nil guards for diagnostic printing

Add a skill document that describes how to use Docker to reproduce Linux-specific CI failures locally, covering all CI jobs with version references from the actual CI config files.

gemini-code-assist bot reviewed Feb 3, 2026

View reviewed changes

cmd/rslint/cmd.go Outdated Show resolved Hide resolved

fansenze force-pushed the chore/update-typescript-go-submodule branch 3 times, most recently from 0a998a9 to 0a2ce79 Compare February 3, 2026 10:01

fansenze force-pushed the chore/update-typescript-go-submodule branch from 0a2ce79 to 0f427d7 Compare February 4, 2026 03:22

docs: add debug-ci skill for reproducing CI failures locally

0125fd3

Add a skill document that describes how to use Docker to reproduce Linux-specific CI failures locally, covering all CI jobs with version references from the actual CI config files.

fansenze force-pushed the chore/update-typescript-go-submodule branch from eb2a053 to 0125fd3 Compare February 4, 2026 03:59

fansenze requested a review from hardfist February 4, 2026 06:41

hardfist approved these changes Feb 4, 2026

View reviewed changes

hardfist enabled auto-merge (squash) February 4, 2026 08:57

hardfist disabled auto-merge February 4, 2026 08:58

hardfist merged commit dd5e109 into main Feb 4, 2026
14 checks passed

hardfist deleted the chore/update-typescript-go-submodule branch February 4, 2026 08:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update typescript-go submodule#454

chore: update typescript-go submodule#454
hardfist merged 2 commits intomainfrom
chore/update-typescript-go-submodule

fansenze commented Feb 3, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 3, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

fansenze commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Changes

Related Links

Checklist

Uh oh!

gemini-code-assist bot commented Feb 3, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fansenze commented Feb 3, 2026 •

edited

Loading