Skip to content

chore: update typescript-go submodule#447

Merged
fansenze merged 2 commits intomainfrom
chore/update-typescript-go-submodule
Jan 30, 2026
Merged

chore: update typescript-go submodule#447
fansenze merged 2 commits intomainfrom
chore/update-typescript-go-submodule

Conversation

@fansenze
Copy link
Copy Markdown
Contributor

@fansenze fansenze commented Jan 29, 2026 •
edited
Loading

Summary

  • Update typescript-go submodule to c3dbd169b1ae2cf30086a0b38df15b4c18ec9c62 (feat/expose-checker-apis)
  • Fix Windows CI disk space issue by running go tests in batches and cleaning build cache after each batch

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@gemini-code-assist
Copy link
Copy Markdown

gemini-code-assist bot commented Jan 29, 2026

Summary of Changes

Hello @fansenze, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request synchronizes the project's dependency on the typescript-go library by updating its submodule reference. This ensures the main project benefits from the latest features and fixes available in the typescript-go repository, specifically integrating changes related to exposing checker APIs.

Highlights

  • Submodule Update: The typescript-go submodule has been updated to commit c3dbd169b1ae2cf30086a0b38df15b4c18ec9c62. This update incorporates a feature that exposes checker APIs, as detailed in the linked upstream pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 29, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the typescript-go submodule. While the update itself is simple, it has implications for the consuming Go code. The new submodule version exposes APIs that were previously internal. The Go code should be updated to use these new public APIs to remove fragile implementations like go:linkname. I've left a specific comment on the change.

@fansenze fansenze force-pushed the chore/update-typescript-go-submodule branch from c0ec90f to b208e87 Compare January 30, 2026 02:47
@fansenze
fix(ci): disable go build cache on Windows to prevent disk space issues
7e42355 
- Run tests in batches of 15 packages on Windows
- Clean build cache after each batch to free disk space
- Add -count=1 flag to disable test result caching
- Remove duplicate testcache cleanup from setup-go action
@fansenze fansenze force-pushed the chore/update-typescript-go-submodule branch from b208e87 to 7e42355 Compare January 30, 2026 03:19
@fansenze fansenze requested a review from hardfist January 30, 2026 03:34
@fansenze fansenze merged commit f5a27b8 into main Jan 30, 2026
14 checks passed
@fansenze fansenze deleted the chore/update-typescript-go-submodule branch January 30, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hardfist hardfist hardfist approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fansenze @hardfist