feat: add glob pattern support for project configuration#439
Closed
zackarychapple wants to merge 3 commits intoweb-infra-dev:mainfrom
Closed
feat: add glob pattern support for project configuration#439zackarychapple wants to merge 3 commits intoweb-infra-dev:mainfrom
zackarychapple wants to merge 3 commits intoweb-infra-dev:mainfrom
Conversation
- Implements glob expansion for project paths as documented at https://rslint.rs/config/ - Uses existing doublestar/v4 dependency for pattern matching - Adds comprehensive test coverage with 7 test cases - Maintains backward compatibility with non-glob paths - Updates rslint's own config to use glob patterns - Adds deduplication to handle overlapping patterns This resolves the FIXME comment about 'enable legacy multi tsconfig project' Changes: - internal/config/loader.go: Add glob detection and expansion logic - internal/config/loader_test.go: Add comprehensive test suite (NEW) - rslint.json: Refactor to use glob patterns Benefits: - Simplifies monorepo configuration (3 lines vs 10+ explicit paths) - Automatically discovers new packages/apps without config updates - Matches documented behavior - No new dependencies - Full backward compatibility Testing: All tests passing: go test ./internal/config/... -v - TestContainsGlobPattern - TestLoadTsConfigsFromRslintConfig_GlobExpansion - TestLoadTsConfigsFromRslintConfig_NoMatches - TestLoadTsConfigsFromRslintConfig_MixedGlobAndNonGlob - TestLoadTsConfigsFromRslintConfig_Deduplication - TestLoadTsConfigsFromRslintConfig_NonExistentNonGlobFile - TestLoadTsConfigsFromRslintConfig_DoubleStarPattern
✅ Deploy Preview for rslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Thanks for the PR! The changes look great, but there are a few CI failures. For the linting error, I think adding |
Author
Contributor
|
@zackarychapple The glob pattern support looks great! Just a couple of things before we can merge:
|
Contributor
|
Hi @zackarychapple, just checking in — do you have time to address the remaining items (rebase + restoring |
Collaborator
|
Can I take this task of addressing remaining items? |
Collaborator
|
I opened #493 to carry this over on top of current main and address the remaining maintainer feedback ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official documentation states that glob patterns work in the project configuration, however this code was commented out waiting for support in ts-go, it appears this support has been added. I verified that this is working for our project.
This resolves the FIXME comment about 'enable legacy multi tsconfig project'
Changes:
Benefits:
Testing:
All tests passing: go test ./internal/config/... -v
Summary
Related Links
Checklist