fix(rule): fix crash in no-misused-new rule caused by missing node.Name().Text() in ComputedPropertyName node#419
Merged
chenjiahan merged 2 commits intomainfrom Dec 26, 2025
Merged
Conversation
✅ Deploy Preview for rslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
hardfist
previously approved these changes
Dec 25, 2025
…me().Text() in ComputedPropertyName node
e0dcfab to
8215d3c
Compare
chenjiahan
approved these changes
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the build errors encountered after bumping
@rslint/corefrom0.1.13to0.1.14.Cause:
no-misused-newrule throws error onComputedPropertyNamedue to missingnode.Name().Text()Related Links
@rslint/core@0.1.13:@rslint/core@0.1.14:@rslint/core@0.1.14with breakpoints revealed that theno-misused-newrule crashes when encountering aComputedPropertyName.Checklist