Merged
Conversation
Contributor
Author
|
@copilot https://github.com/web-infra-dev/rslint/actions/runs/16460137846/job/46525610940?pr=41#step:12:21 the ci color seems wrong can you help fix it |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR configures the rslint project to use its own linting tool (rslint) for code quality checks. The changes establish a consistent linting workflow across the project and integrate it into the CI pipeline.
- Adds lint scripts to package.json files to enable running rslint across the project
- Updates TypeScript configuration and binary settings for the rslint package
- Integrates linting into the GitHub Actions CI workflow
- Removes redundant Go module caching and simplifies CI configuration
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/vscode-extension/package.json | Adds lint script using rslint with TypeScript configuration |
| packages/vscode-extension/tsconfig.build.json | Updates extends path to use root-level TypeScript build configuration |
| packages/rslint/package.json | Updates binary name and adds verbose flag to Go build |
| package.json | Adds root-level lint script to run linting across all packages |
| .prettierignore | Excludes additional VS Code test directory from formatting |
| .github/workflows/ci.yml | Integrates linting step and simplifies Go setup configuration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.