Conversation
✅ Deploy Preview for rslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds text content to AST nodes in the playground component by including a text property in the ASTNode interface and populating it from the node's text content.
- Added
textproperty to the ASTNode interface definition - Populated the
textproperty in the RemoteNodeToEstree function to capture node text content
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| start: node.pos, | ||
| end: node.end, | ||
| text: node.text, |
There was a problem hiding this comment.
[P1] Access Node.text which is not part of @rslint/api types
The AST conversion now reads node.text, but the imported Node type is just the TypeScript AST interface re‑exported from @typescript/api, which does not define a text property. Under the website’s strict TypeScript configuration this line produces Property 'text' does not exist on type 'Node', causing the playground build to fail. If the intent is to show node text, it needs to be derived from the source (e.g. via RemoteSourceFile or specific token types) instead of accessing a nonexistent field.
Useful? React with 👍 / 👎.
Summary
Related Links
Checklist