Skip to content

chore: use tsgo instead of tsc#338

Merged
hardfist merged 2 commits intomainfrom
yj-use-tsgo
Sep 8, 2025
Merged

chore: use tsgo instead of tsc#338
hardfist merged 2 commits intomainfrom
yj-use-tsgo

Conversation

@hardfist
Copy link
Copy Markdown
Contributor

@hardfist hardfist commented Sep 5, 2025

Summary

use tsgo instead of tsc to catch tsgo bugs

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 5, 2025 04:54
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 5, 2025

Deploy Preview for rslint ready!

Name Link
🔨 Latest commit 59671fa
🔍 Latest deploy log https://app.netlify.com/projects/rslint/deploys/68be6b1e0ed44b00088e2f17
😎 Deploy Preview https://deploy-preview-338--rslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the TypeScript compiler (tsc) with tsgo across the monorepo to help catch bugs in the tsgo implementation. The change systematically updates build and development scripts to use the new compiler.

Key changes:

  • Replaces tsc with tsgo in all package.json build scripts
  • Adds @typescript/native-preview dependency to the root package
  • Updates both build and development/watch commands consistently

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/vscode-extension/package.json Updates test script to use tsgo instead of tsc
packages/rule-tester/package.json Replaces tsc with tsgo in build and dev scripts
packages/rslint/package.json Updates JavaScript build and dev scripts to use tsgo
packages/rslint-wasm/package.json Changes build:js script to use tsgo for TypeScript compilation
packages/rslint-api/package.json Updates compile script to use tsgo instead of tsc
package.json Replaces tsc with tsgo in typecheck script and adds new dependency
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@hardfist
Copy link
Copy Markdown
Contributor Author

hardfist commented Sep 8, 2025

@codex review this

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

@hardfist hardfist merged commit 0b389e7 into main Sep 8, 2025
17 checks passed
@hardfist hardfist deleted the yj-use-tsgo branch September 8, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants