Skip to content

chore: show lint annotations in ci#336

Merged
hardfist merged 2 commits intomainfrom
yj/lint-annotation
Sep 4, 2025
Merged

chore: show lint annotations in ci#336
hardfist merged 2 commits intomainfrom
yj/lint-annotation

Conversation

@hardfist
Copy link
Copy Markdown
Contributor

@hardfist hardfist commented Sep 4, 2025

Summary

dogfooding github annotations for rslint

Related Links

#326

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 4, 2025 08:06
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 4, 2025

Deploy Preview for rslint ready!

Name Link
🔨 Latest commit a531290
🔍 Latest deploy log https://app.netlify.com/projects/rslint/deploys/68ba1f5cfc57f00008b1683e
😎 Deploy Preview https://deploy-preview-336--rslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances CI feedback by enabling lint result annotations to be displayed directly in GitHub pull requests and commits. The changes configure GitHub Actions permissions and modify the lint command to output results in GitHub's annotation format.

  • Adds required GitHub Actions permissions for writing check results and commit statuses
  • Modifies the lint command to use GitHub format output for better CI integration

@Thiry1
Copy link
Copy Markdown
Contributor

Thiry1 commented Sep 4, 2025

Ah, it should have been ::warning not ::warn. I'll fix it.

@hardfist
Copy link
Copy Markdown
Contributor Author

hardfist commented Sep 4, 2025

Ah, it should have been ::warning not ::warn. I'll fix it.

@Thiry1 it works now, thanks!
image

@hardfist hardfist merged commit ac0e383 into main Sep 4, 2025
17 checks passed
@hardfist hardfist deleted the yj/lint-annotation branch September 4, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants