Conversation
✅ Deploy Preview for rslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the shim encoder module to support the JavaScript API for AST functionality by exporting the encoder module. The main purpose is to enable JavaScript access to TypeScript AST encoding capabilities through the shim layer.
Key changes:
- Added encoder module exports to the shim generation tool
- Created new shim packages for API and encoder modules
- Updated TypeScript-Go dependency version across all modules
Reviewed Changes
Copilot reviewed 23 out of 41 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/gen_shims/main.go | Added canBeExported function and new packages "api" and "api/encoder" to shimming list |
| shim/api/shim.go | New generated shim file exposing API module functionality |
| shim/api/encoder/shim.go | New generated shim file exposing encoder module for AST encoding |
| internal/api/api.go | Added EncodeAST function that wraps encoder.EncodeSourceFile |
| go.mod | Updated TypeScript-Go dependency and added new shim module replacements |
| tools/update-typescript-go.sh | Commented out TypeScript-Go update commands |
| Various go.mod files | Updated TypeScript-Go dependency version from 20250814234431 to 20250829050502 |
abd9b9b to
e5b041a
Compare
e5b041a to
4505ec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
export encoder module to support js api for ast