refactor: use monaco-editor for playground#309
Merged
Conversation
✅ Deploy Preview for rslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors the playground component to use Monaco Editor instead of a custom textarea-based editor implementation, providing better syntax highlighting, diagnostics display, and TypeScript language support.
- Replaces custom editor with Monaco Editor for enhanced code editing experience
- Simplifies playground architecture by removing complex custom UI components
- Updates WASM package exports and removes debug console logs
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| website/theme/components/Playground/index.tsx | New simplified playground component using Monaco Editor |
| website/theme/components/Playground/Editor.tsx | Monaco Editor wrapper component with diagnostic integration |
| website/theme/components/Playground/Editor.css | Basic styling for Monaco Editor container |
| website/theme/components/Playground/index.css | Layout adjustments for new playground structure |
| website/theme/components/Playground.tsx | Removed old custom editor implementation |
| website/theme/components/Playground.css | Removed custom editor styling |
| website/rspress.config.ts | Added Monaco Editor webpack configuration and disabled SSG |
| website/package.json | Added Monaco Editor dependency and updated WASM package version |
| website/docs/en/playground/index.mdx | Updated import path for new playground structure |
| packages/rslint-wasm/src/worker.ts | Removed debug console logs |
| packages/rslint-wasm/src/index.ts | Improved exports and type definitions |
| packages/rslint-wasm/scripts/build.mjs | Updated build entry point |
| packages/rslint-wasm/package.json | Updated version and added type definitions |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use monaco-editor for playground