Conversation
✅ Deploy Preview for rslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for running rslint in browser environments through WebAssembly (WASM), extending the existing Node.js-only architecture to support both Node.js and browser environments.
Key changes include:
- Refactored the core rslint service to support multiple environments through a common interface
- Added browser-specific implementation using web workers and WASM
- Created a new
@rslint/wasmpackage for browser usage
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rslint/src/types.ts | Added shared type definitions for the rslint IPC protocol |
| packages/rslint/src/service.ts | Refactored to use environment-specific service implementations |
| packages/rslint/src/node.ts | Extracted Node.js-specific implementation from main service |
| packages/rslint/src/browser.ts | Added browser implementation using web workers |
| packages/rslint/src/index.ts | Updated exports and convenience functions to use new architecture |
| packages/rslint-wasm/* | New package containing WASM build scripts, worker implementation, and browser example |
| internal/config/loader.go | Added debug logging for configuration loading |
| internal/api/api.go | Minor formatting change removing blank line |
| cmd/rslint/signal_*.go | Added platform-specific signal handling for WASM support |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
3ea0aed to
2191146
Compare
d7cdbc4 to
9d93857
Compare
8fde029 to
e763a0a
Compare
CPunisher
reviewed
Aug 27, 2025
CPunisher
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support run rslint on browser
support expose tsgo ast in following pr