Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request sets up test infrastructure for the VS Code extension, refactoring the TypeScript configuration to support both build and test environments. The changes include setting up Mocha test framework, VS Code test runner integration, and removing the language server implementation.
Key changes:
- Restructured TypeScript configuration with separate build and test configs
- Added comprehensive test setup using Mocha and VS Code test framework
- Removed existing language server implementation from server.ts
- Updated CI workflow to run extension tests with proper display setup
Reviewed Changes
Copilot reviewed 15 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/vscode-extension/tsconfig.test.json | New test-specific TypeScript configuration |
| packages/vscode-extension/tsconfig.build.json | New build-specific TypeScript configuration extending base config |
| packages/vscode-extension/tsconfig.json | Refactored base config to include test files |
| packages/vscode-extension/src/server.ts | Removed entire language server implementation |
| packages/vscode-extension/tests/suite/index.ts | Test runner setup using Mocha and fast-glob |
| packages/vscode-extension/tests/suite/extension.test.ts | Basic extension test for diagnostics |
| packages/vscode-extension/tests/runTest.ts | VS Code test launcher configuration |
| packages/vscode-extension/package.json | Added test dependencies and scripts |
| .github/workflows/ci.yml | Updated CI to run extension tests with xvfb for Linux |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/vscode-extension/tests/suite/extension.test.ts:21
- The test only verifies that there are 0 diagnostics, but doesn't test the actual functionality of the extension when there should be diagnostics present.
assert.equal(diagnostics.length, 0);
b744977 to
4159a49
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hardfist
approved these changes
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.