Conversation
✅ Deploy Preview for rslint canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash that occurs when the LSP service processes non-TypeScript files by returning a proper diagnostic response structure instead of an empty one.
Key changes:
- Return a properly structured
RelatedFullDocumentDiagnosticReportOrUnchangedDocumentDiagnosticReportfor non-TypeScript files - Move diagnostic variable declaration outside the TypeScript file check to be reusable
colinaaa
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typescirpt-go has a check for returned diagnostics to ensure at least return non-nil for diagnosticReport https://github.com/microsoft/typescript-go/blob/bca9518930e5bc91885a9c959283bab4b4de015c/internal/lsp/lsproto/lsp_generated.go#L24559
return empty FullDocumentDiagnosticReport to avoid crash