Skip to content

docs: add Modern.js Module migration docs#378

Merged
Timeless0911 merged 8 commits intoweb-infra-dev:mainfrom
YanPes:docs/add-modern-js-module-docs
Nov 7, 2024
Merged

docs: add Modern.js Module migration docs#378
Timeless0911 merged 8 commits intoweb-infra-dev:mainfrom
YanPes:docs/add-modern-js-module-docs

Conversation

@YanPes
Copy link
Copy Markdown
Contributor

@YanPes YanPes commented Nov 6, 2024 •
edited by Timeless0911
Loading

Summary

This PR adds documentation regarding the migration of Modern.js Module projects to Rslib

Related Links

closes: #377

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

yannik.peschke added 2 commits November 6, 2024 13:51
docs/add-error-catalog-entries-for-mf-types
eb7df4f 
* Add documentation for the migration process from Modern.js module towards Rslib
docs/add-error-catalog-entries-for-mf-types
fab7c0f 
* Remove unneeded commas
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 6, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Timeless0911
❌ yannik.peschke

yannik.peschke seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 8c23df1
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/672c37edfe18ba0008524156
😎 Deploy Preview https://deploy-preview-378--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@YanPes
Copy link
Copy Markdown
Contributor Author

YanPes commented Nov 6, 2024

signed the CLA

@Timeless0911 Timeless0911 changed the title Docs/add modern js module docs docs: add Modern.js Module migration docs Nov 7, 2024
Timeless0911
Timeless0911 reviewed Nov 7, 2024
View reviewed changes
@Timeless0911
Copy link
Copy Markdown
Contributor

Timeless0911 commented Nov 7, 2024

Awesome work! We can use this migration document for now, and we will complete a more complete configuration map and provide codemod in the future.

@Timeless0911
Copy link
Copy Markdown
Contributor

Timeless0911 commented Nov 7, 2024

signed the CLA

@YanPes The CI state is still blocked, can you confirm it?

@YanPes
Copy link
Copy Markdown
Contributor Author

YanPes commented Nov 7, 2024 •
edited
Loading

signed the CLA

@YanPes The CI state is still blocked, can you confirm it?

@Timeless0911 : Yes I have signed it. Here is the "proof". I checked locally. It seems I accidentally did not overwrite my git config user.email for the forked repo and pushed my changes with my business email instead which is already linked to a business account. Cannot bind it to this one.
Screenshot 2024-11-07 074840

Will not happen a second time - i adapted the configs. Sorry for the inconvenience

@Timeless0911
Copy link
Copy Markdown
Contributor

Timeless0911 commented Nov 7, 2024

@YanPes Haha, never mind, I always forgot to switch accounts when I re-clone the repository too. I can just skip the cla CI check for this PR. Thank you!

@Timeless0911 Timeless0911 merged commit eaa07c8 into web-infra-dev:main Nov 7, 2024
@YanPes YanPes deleted the docs/add-modern-js-module-docs branch November 7, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees

No one assigned

Labels

change: docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Modern.js Module migration guide

3 participants

@YanPes @CLAassistant @Timeless0911