chore: convert prebundle config files to ts#1548
Merged
Timeless0911 merged 2 commits intomainfrom Mar 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Converts prebundle configuration files from JSDoc-based typing to TypeScript Config typing with satisfies Config, aligning with the migration pattern used in rsbuild.
Changes:
- Replace
// @ts-check+ JSDoc@typewithimport type { Config } from 'prebundle'andsatisfies Config. - Migrate
rsbuild-plugin-dtsconfig from.mjsto.ts. - Update the “Tip” comment wording to mention
dts.aliasas an alternative totsconfig.json#paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/plugin-dts/prebundle.config.ts | New TS-based prebundle config using satisfies Config. |
| packages/plugin-dts/prebundle.config.mjs | Removes the previous JSDoc-typed ESM config. |
| packages/core/prebundle.config.ts | Switches existing config typing from JSDoc to satisfies Config and updates the Tip text. |
Comments suppressed due to low confidence (1)
packages/core/prebundle.config.ts:4
- End the Tip sentence with a period for consistent punctuation in this block comment.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45d3d51e3c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert the prebundle config files in
@rslib/coreandrsbuild-plugin-dtsfrom.mjsto.ts, following the same migration pattern used in rsbuild.This switches the configs from JSDoc typing to
import type { Config } from 'prebundle'withsatisfies Config, while keeping the existing prebundle entries unchanged.Related Links
Checklist