perf(deps): upgrade tinyglobby and use dynamic import#1544
Merged
Timeless0911 merged 4 commits intomainfrom Mar 19, 2026
Merged
perf(deps): upgrade tinyglobby and use dynamic import#1544Timeless0911 merged 4 commits intomainfrom
Timeless0911 merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades tinyglobby to v0.2.15, removes the temporary Renovate ignore, and adjusts how tinyglobby is consumed/prebundled across packages to avoid the previous prebundle/alias approach in @rslib/core.
Changes:
- Bump
tinyglobbydependency to^0.2.15inpackages/coreandpackages/plugin-dts. - In
@rslib/core, stop prebundling/aliasingtinyglobbyand switch to lazy loading viaawait import('tinyglobby'). - In
rsbuild-plugin-dts, keep prebundlingtinyglobbybut skip generating its DTS viaignoreDts.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/plugin-dts/tsconfig.json | Removes the tinyglobby path alias to stop pointing TS types at the compiled bundle. |
| packages/plugin-dts/prebundle.config.mjs | Switches tinyglobby prebundle entry to an object with ignoreDts: true. |
| packages/plugin-dts/package.json | Updates tinyglobby version to ^0.2.15. |
| packages/core/tsconfig.json | Removes the tinyglobby path alias now that it’s no longer prebundled. |
| packages/core/src/config.ts | Replaces static glob import with dynamic import at point-of-use. |
| packages/core/rslib.config.ts | Removes externals mapping for the previously prebundled tinyglobby. |
| packages/core/prebundle.config.mjs | Removes tinyglobby from prebundled dependencies list. |
| packages/core/package.json | Updates tinyglobby version to ^0.2.15. |
| .github/renovate.json5 | Removes the temporary Renovate ignore for tinyglobby. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
fi3ework
reviewed
Mar 19, 2026
Member
fi3ework
left a comment
There was a problem hiding this comment.
any benchmark for the improvement?
Contributor
Author
All these perf related to deps only reduce some cjs-module-lexer time when parse cjs in startup. |
7acc8fb to
153d082
Compare
fi3ework
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade tinyglobby to v0.2.15 and remove the temporary Renovate ignore for it.
Stop prebundling tinyglobby and load it with
await import('tinyglobby')when resolving glob entries.Related Links
Checklist