test(create-rslib): split parseTemplateName into separate module#1514
Merged
Timeless0911 merged 2 commits intomainfrom Mar 5, 2026
Merged
test(create-rslib): split parseTemplateName into separate module#1514Timeless0911 merged 2 commits intomainfrom
Timeless0911 merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors create-rslib by extracting parseTemplateName into a standalone module while preserving the existing public API via a re-export from src/index.ts. This avoids importing the CLI entry module at runtime in unit tests, reducing intermittent test hangs/failures.
Changes:
- Moved
parseTemplateNamefrompackages/create-rslib/src/index.tsintopackages/create-rslib/src/parseTemplateName.ts. - Re-exported
parseTemplateNamefromsrc/index.tsto keep existing imports working. - Updated unit tests to import
parseTemplateNamefrom the new standalone module and keepLangas a type-only import.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/create-rslib/test/index.test.ts | Switches to importing parseTemplateName from the new module to avoid CLI side effects during tests. |
| packages/create-rslib/src/parseTemplateName.ts | New dedicated module containing parseTemplateName logic. |
| packages/create-rslib/src/index.ts | Imports and re-exports parseTemplateName, removing the inline implementation. |
9aoy
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
parseTemplateNamefrom the CLI entry module so unit tests no longer import runtime CLI side effects.parseTemplateNamefrompackages/create-rslib/src/index.tsintopackages/create-rslib/src/parseTemplateName.tsparseTemplateNamefromindex.tsto keep external API usage unchangedpackages/create-rslib/test/index.test.tsto importparseTemplateNamefrom the standalone moduleunit-createworker crashes/hangsRelated Links
Checklist
Validation
pnpm test:unitpassedpnpm test:unitruns passed