fix: should throw error when custom config file not found#1403
Merged
Timeless0911 merged 1 commit intomainfrom Dec 24, 2025
Merged
fix: should throw error when custom config file not found#1403Timeless0911 merged 1 commit intomainfrom
Timeless0911 merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where specifying a non-existent custom config file with the --config flag would silently fall back to the default config instead of throwing an error. The fix ensures that when a user explicitly provides a custom config path, the build fails immediately if that file doesn't exist.
Key changes:
- Changed from logging a warning to throwing an error when a custom config file is not found
- Added an integration test to verify the error is thrown correctly
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/core/src/config.ts |
Changed resolveConfigPath to throw an error instead of logging a warning when a custom config file doesn't exist |
tests/integration/cli/build/build.test.ts |
Added test case to verify that a non-existent custom config file causes the build to fail with an appropriate error message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Timeless0911
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: should throw error when custom config file not found.
expect throw
config not founderror, but fallback to default config.Related Links
web-infra-dev/rsbuild#6828
Checklist