Skip to content

Commit ffb7cbf

Browse files
committed
refactor(core): use named import from node:module for require shim
1 parent 3f64b6c commit ffb7cbf

4 files changed

Lines changed: 8 additions & 12 deletions

File tree

packages/core/src/plugins/shims.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ export const pluginCjsImportMetaUrlShim = (): RsbuildPlugin => ({
1717
});
1818

1919
const requireShim = `// Rslib ESM shims
20-
import __rslib_shim_module__ from 'module';
21-
const require = /*#__PURE__*/ __rslib_shim_module__.createRequire(import.meta.url);
20+
import { createRequire } from "node:module";
21+
const require = /*#__PURE__*/ createRequire(import.meta.url);
2222
`;
2323

2424
export const pluginEsmRequireShim = (): RsbuildPlugin => ({

tests/integration/shims/index.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ describe('ESM shims', async () => {
5151

5252
test('require', async () => {
5353
expect(entries.esm2).toMatchInlineSnapshot(`
54-
"import __rslib_shim_module__ from 'module';
55-
const require = /*#__PURE__*/ __rslib_shim_module__.createRequire(import.meta.url);
54+
"import { createRequire } from "node:module";
55+
const require = /*#__PURE__*/ createRequire(import.meta.url);
5656
const randomFile = require(process.env.RANDOM_FILE);
5757
export { randomFile };
5858
"

website/docs/en/config/lib/shims.mdx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,10 +168,8 @@ Options:
168168
the ESM output will be transformed to:
169169
170170
```js
171-
import __rslib_shim_module__ from 'module';
172-
const require = /*#__PURE__*/ __rslib_shim_module__.createRequire(
173-
import.meta.url,
174-
);
171+
import { createRequire } from 'node:module';
172+
const require = /*#__PURE__*/ createRequire(import.meta.url);
175173
// dynamic require
176174
require(SOME_VALUE_IN_RUNTIME);
177175
// require.resolve

website/docs/zh/config/lib/shims.mdx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,10 +168,8 @@ const defaultShims = {
168168
ESM 产物将被转换为:
169169
170170
```js
171-
import __rslib_shim_module__ from 'module';
172-
const require = /*#__PURE__*/ __rslib_shim_module__.createRequire(
173-
import.meta.url,
174-
);
171+
import { createRequire } from 'node:module';
172+
const require = /*#__PURE__*/ createRequire(import.meta.url);
175173
// dynamic require
176174
require(SOME_VALUE_IN_RUNTIME);
177175
// require.resolve

0 commit comments

Comments
 (0)