Skip to content

fix: bailout_reason data when rspack repo#1492

Merged
yifancong merged 2 commits intomainfrom
fix/bailout-reason-rspack
Jan 19, 2026
Merged

fix: bailout_reason data when rspack repo#1492
yifancong merged 2 commits intomainfrom
fix/bailout-reason-rspack

Conversation

@yifancong
Copy link
Contributor

@yifancong yifancong commented Jan 17, 2026

Summary

Background

Rspack encountered issues when reporting bailout_reason data, such as [performance bottlenecks/data missing problems/poor presentation (describe the problem)].

Changes

  • Optimized the processing logic of bailout_reason data.
  • Fixed a bug where data could not be correctly reported in certain scenarios.

Related Links

Copilot AI review requested due to automatic review settings January 17, 2026 05:59
@netlify
Copy link

netlify bot commented Jan 17, 2026

Deploy Preview for rsdoctor ready!

Name Link
🔨 Latest commit b5ec411
🔍 Latest deploy log https://app.netlify.com/projects/rsdoctor/deploys/696b253eff7614000815341a
😎 Deploy Preview https://deploy-preview-1492--rsdoctor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes bailout reason data by filtering out "ModuleConcatenation bailout" messages from the bailout reasons collected for modules. These messages are deemed less useful for analysis and are now excluded when processing module graph data from both webpack stats and Rspack native plugins.

Changes:

  • Added filtering logic to exclude ModuleConcatenation bailout messages when processing optimizationBailout data
  • Modified bailoutReason serialization to always include the field regardless of brief mode
  • Added comprehensive test coverage for the new filtering behavior in Rspack transform

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/graph/src/transform/module-graph/transform.ts Filters out ModuleConcatenation bailout messages from normal module optimizationBailout data
packages/graph/src/graph/module-graph/module.ts Removes isBrief condition so bailoutReason is always serialized
packages/core/src/build-utils/build/module-graph/rspack/transform.ts Adds bailoutReason processing with ModuleConcatenation filtering for Rspack native module graph
packages/core/tests/build/utils/rspack-transform.test.ts Adds comprehensive test coverage for bailoutReason filtering in Rspack transform

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yifancong yifancong requested a review from fi3ework January 19, 2026 10:49
Copy link
Member

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. meaningless desc
  2. wrong conventional PR title

@yifancong yifancong changed the title optimize: bailout_reason data when rspack repo refactor: bailout_reason data when rspack repo Jan 19, 2026
@yifancong
Copy link
Contributor Author

  1. meaningless desc
  2. wrong conventional PR title

@fi3ework Done

@fi3ework fi3ework changed the title refactor: bailout_reason data when rspack repo fix: bailout_reason data when rspack repo Jan 19, 2026
@fi3ework
Copy link
Member

should use fix since refactor means no changing to functionality.

@yifancong yifancong merged commit 9aa7eef into main Jan 19, 2026
17 checks passed
@yifancong yifancong deleted the fix/bailout-reason-rspack branch January 19, 2026 11:06
@yifancong yifancong mentioned this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants