fix: the problem of the formatAssetName function#1482
Merged
Conversation
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the formatAssetName function where the hash pattern regex was incorrectly matching common words like "basic" and "main" that don't contain digits, causing them to be treated as hashes and removed from filenames.
Changes:
- Updated the
hashPatternregex to be more strict, requiring either a hex string (4-32 chars) or an alphanumeric string that contains at least one digit - Added comprehensive test cases to verify that common words without digits are preserved and actual hash patterns are correctly removed
- Updated pnpm-lock.yaml with compiled dependency entries
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/utils/src/common/graph/assets.ts | Modified hash pattern regex to prevent matching pure alphabetic words by requiring at least one digit in non-hex patterns |
| packages/utils/tests/common/graph.test.ts | Added test cases verifying that filenames with common words (basic, main) are preserved while actual hashes are removed |
| pnpm-lock.yaml | Added empty entries for compiled packages (maintenance update) |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SoonIter
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: the problem of the formatAssetName function
When formatting the path
config/config-basic.[hash].html, the result isconfig/config.html, but it should beconfig/config-basic.html.Related Links