fix: avoid printing the version number multiple times#1470
Merged
Conversation
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where the Rsdoctor version number was being printed multiple times by implementing a module-level flag to track whether the greeting has already been displayed. The fix ensures that the version greeting is only shown once per process, even when multiple compiler instances or child compilers are involved.
Key Changes
- Introduced a
hasGreetedmodule-level flag in both webpack and rspack plugins - Added conditional logic to check the flag and
compiler.isChild()before printing the greeting - Applied consistent implementation across both webpack-plugin and rspack-plugin packages
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/webpack-plugin/src/plugin.ts | Added module-level hasGreeted flag and conditional logic in apply() method to prevent duplicate version greetings |
| packages/rspack-plugin/src/plugin.ts | Added module-level hasGreeted flag and conditional logic in apply() method to prevent duplicate version greetings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fansenze
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: avoid printing the version number multiple times
Related Links