Conversation
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes sourcemap resolution issues by improving how relative and absolute source paths are resolved in sourcemaps. The changes add support for sourceRoot handling and proper resolution of sourcemap file locations.
Key changes:
- Enhanced
bindContextCacheto handle relative paths using sourcemap directory andsourceRootfrom sourcemap metadata - Added
sourceMapPathtracking throughcollectSourceMaps,handleAfterEmitAssets, andhandleEmitAssetsfunctions - Removed rspack-specific skip condition in
changeDevtoolModuleFilenameto apply devtool configuration to both webpack and rspack
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/inner-plugins/plugins/sourcemapTool.ts | Core fix: Added sourceMapDir and sourceRoot parameters for proper relative path resolution, made sourceMapFilenameRegex optional, enhanced path resolution logic |
| packages/core/src/inner-plugins/plugins/bundle.ts | Removed rspack exclusion from devtool module filename configuration |
| packages/sdk/src/sdk/sdk/index.ts | Added resolveFilePath helper function to handle root-relative and relative paths when inlining scripts and styles |
| packages/core/src/inner-plugins/plugins/ensureModulesChunkGraph.ts | Added optimizationBailout flag to stats options |
| packages/types/src/plugin/baseStats.ts | Added optimizationBailout optional property to StatsOptionsObj interface |
| examples/rsbuild-minimal/rsbuild.config.ts | Removed commented-out mode configuration line |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b9b622c to
f0dcdd8
Compare
fix: sourcemap tool problem fix: sourcemap tool problem fix: sourcemap tool problem fix: sourcemap tool problem fix: sourcemap tool problem fix: sourcemap tool problem
f0dcdd8 to
4b1147b
Compare
9aoy
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If output.devtoolModuleFilenameTemplate = (info) => toPosixPath(info), i.e. the sources are relative paths without 'webpack://' or 'file://', that case wasn't handled properly before — this PR adds compatibility for it.
Related Links