Skip to content

chore: use pnpm to run build scripts#7256

Merged
chenjiahan merged 1 commit intomainfrom
replace_nx_0228
Feb 28, 2026
Merged

chore: use pnpm to run build scripts#7256
chenjiahan merged 1 commit intomainfrom
replace_nx_0228

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan commented Feb 28, 2026

Summary

Rslib & Tsgo are fast enough, this PR uses pnpm to run build scripts:

  • replace nx commands with pnpm equivalents in build scripts
  • remove nx configuration files and dependencies

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings February 28, 2026 06:18
@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector bot commented Feb 28, 2026

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Feb 28, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on simplifying the project's build infrastructure by transitioning from nx to pnpm for managing and executing build tasks. The change aims to reduce complexity and dependencies by removing nx configurations and commands, replacing them with native pnpm filtering capabilities for monorepo operations. This results in a more lightweight and potentially faster build environment, as indicated by the author's note on Rslib and Tsgo performance.

Highlights

  • Build Tool Migration: Migrated the project's build scripts from nx commands to pnpm equivalents, streamlining the build process.
  • Dependency Cleanup: Removed nx as a development dependency and eliminated its configuration files, resulting in a cleaner project setup and reduced pnpm-lock.yaml size.
  • Documentation Updates: Updated AGENTS.md and CONTRIBUTING.md to reflect the new pnpm build commands, ensuring documentation aligns with the current development workflow.
Changelog
  • AGENTS.md
    • Updated the build command from npx nx build @rsbuild/core to pnpm --filter core run build.
  • CONTRIBUTING.md
    • Updated the build command from npx nx build @rsbuild/core to pnpm --filter core run build.
  • biome.json
    • Removed the !**/.nx exclusion from the ignore paths.
  • nx.json
    • Removed the entire nx configuration file.
  • package.json
    • Modified the build script to use pnpm --filter "./packages/*" --filter "./scripts/*" run build.
    • Modified the prebundle script to use pnpm --filter "./packages/*" run prebundle.
    • Updated the prepare script to execute pnpm prebundle before pnpm build.
    • Removed nx from devDependencies.
  • pnpm-lock.yaml
    • Removed numerous nx-related and other unused package entries, reflecting the dependency cleanup.
Activity
  • The author noted that 'Rslib & Tsgo are fast enough', implying a performance-driven decision to move away from nx.
  • The pull request includes a checklist for 'Tests updated (or not required)' and 'Documentation updated (or not required)', indicating standard development practices are being followed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully replaces nx with pnpm for running build scripts, which simplifies the build setup. The changes to package.json scripts and the removal of nx-related files are appropriate. I have a couple of suggestions regarding script parallelism to ensure performance is not degraded compared to the previous setup.

Copilot AI reviewed Feb 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the repo’s build orchestration from Nx to pnpm-driven workspace scripts, removing Nx configuration and dependencies.

Changes:

  • Replaced Nx-based root build/prebundle scripts with pnpm --filter ... run ... equivalents.
  • Removed Nx dependency and configuration (nx.json) and updated related tooling ignores.
  • Updated contributor/agent docs to use pnpm commands instead of npx nx.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pnpm-lock.yaml Removes nx and related transitive dependencies; updates lock snapshots accordingly.
package.json Replaces Nx build orchestration with pnpm workspace filtering; adjusts prepare flow.
nx.json Deletes Nx configuration from the repo.
biome.json Removes .nx ignore now that Nx is being removed.
CONTRIBUTING.md Updates build instructions from Nx to pnpm.
AGENTS.md Updates focused-work build command from Nx to pnpm.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit 0d0def7 into main Feb 28, 2026
10 checks passed
@chenjiahan chenjiahan deleted the replace_nx_0228 branch February 28, 2026 06:29
@Timeless0911 Timeless0911 mentioned this pull request Feb 28, 2026
Merged
2 tasks
@chenjiahan chenjiahan mentioned this pull request Mar 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenjiahan