Skip to content

test: add error recovery overlay test case#6821

Merged
chenjiahan merged 4 commits intomainfrom
overlay_recovery_1222
Dec 22, 2025
Merged

test: add error recovery overlay test case#6821
chenjiahan merged 4 commits intomainfrom
overlay_recovery_1222

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

Added a new test that simulates a build error by introducing a syntax error, checks for the error overlay, then fixes the error and verifies that the overlay is hidden after a successful rebuild.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 22, 2025 13:35
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 22, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 59449ed
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/6949510f59132c0008391b46
😎 Deploy Preview https://deploy-preview-6821--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 68 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new end-to-end test case for error overlay recovery functionality. The test verifies that the error overlay appears when a syntax error is introduced and disappears after the error is fixed and a successful rebuild occurs.

  • Adds test infrastructure files (React components, Rsbuild config) for the error-recovery test case
  • Creates a test that introduces a JSX syntax error, waits for build failure, fixes the error, and verifies overlay dismissal

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
e2e/cases/overlay/error-recovery/index.test.ts Test case that verifies error overlay is hidden after resolving a build error
e2e/cases/overlay/error-recovery/src/index.jsx React entry point for the test application
e2e/cases/overlay/error-recovery/src/App.jsx Simple React component used in the error recovery test
e2e/cases/overlay/error-recovery/rsbuild.config.ts Rsbuild configuration for the error-recovery test case

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit a3f3094 into main Dec 22, 2025
11 checks passed
@chenjiahan chenjiahan deleted the overlay_recovery_1222 branch December 22, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants