feat: add option to disable asset prefix in manifest#6681
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR adds a new prefix option to the output.manifest configuration, allowing developers to control whether asset URLs in the generated manifest file should include the static asset prefix (dev.assetPrefix / output.assetPrefix).
Key Changes:
- Added
prefixboolean option toManifestObjectConfigtype with a default value oftrue - Updated manifest generation logic to conditionally apply asset prefixes based on the new option
- Added test coverage for the new feature with
prefix: false
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/types/config.ts | Added the prefix configuration option to the ManifestObjectConfig type with appropriate JSDoc documentation |
| packages/core/src/plugins/manifest.ts | Implemented prefix control logic in manifest generation, including type updates, normalization, and conditional asset URL prefix application |
| e2e/cases/manifest/remove-prefix/src/index.js | Test fixture entry point that imports React and CSS for testing prefix removal |
| e2e/cases/manifest/remove-prefix/src/index.css | Test fixture CSS file |
| e2e/cases/manifest/remove-prefix/index.test.ts | E2E test verifying manifest generation without asset prefix when prefix: false is configured |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Add a new
prefixoption to theoutput.manifestconfiguration to control whether asset URLs should include the static asset prefix.This allows more flexibility in manifest generation for different deployment scenarios.
Checklist