fix: preserve status message in gzip middleware#6663
Merged
chenjiahan merged 3 commits intomainfrom Nov 30, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the gzip middleware where custom HTTP status messages were being lost when the middleware deferred the writeHead call. The fix ensures that both the status code and the optional status message are preserved and properly applied.
Key changes:
- Added
writeHeadMessagevariable to capture custom status messages - Updated
writeHeadoverride to correctly distinguish between the two signature overloads (with/without status message) - Modified the
startfunction to pass the status message when calling the originalwriteHead
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeHeadwriteHeadare applied without misinterpreting status messagesTesting
Codex Task