refactor: rename connection to socket for clarity#5850
Merged
chenjiahan merged 2 commits intomainfrom Aug 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors WebSocket-related code by renaming the variable 'connection' to 'socket' throughout both server and client implementations to improve code clarity and better reflect the variable's purpose.
- Renamed 'connection' parameter to 'socket' in server-side WebSocket handling methods
- Updated all references from 'connection' to 'socket' in client-side WebSocket code
- Improved readyState comparison by using named constant instead of magic number
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/server/socketServer.ts | Renamed connection parameter to socket in onConnect and send methods, eliminated intermediate variable assignment |
| packages/core/src/client/hmr.ts | Renamed global connection variable to socket and updated all references throughout WebSocket event handlers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The variable 'connection' was renamed to 'socket' to better reflect its purpose and improve code readability. This change affects both server and client WebSocket implementations.
Checklist